From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +RTLCO2P32m+WRkAWB0awg (envelope-from ) for ; Wed, 15 Apr 2026 09:17:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fDhpQIZM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B88C51E0B1; Wed, 15 Apr 2026 09:17:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DBF2F1E0B1 for ; Wed, 15 Apr 2026 09:17:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 690E04BA2E0E for ; Wed, 15 Apr 2026 13:17:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 690E04BA2E0E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fDhpQIZM Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 890844BA2E07 for ; Wed, 15 Apr 2026 13:17:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 890844BA2E07 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 890844BA2E07 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776259024; cv=none; b=U1+pnuVS2VSf6Tw01+FwcYqZxm6W1VqY5FP/pVFUunZyXVbCCYFx6jwS4gaAlgVUYiC+eZmpf3QHL2ahT4O0kqEgXlUH3XE7ZDaw4BR6Fy7TRIk9D5hkBBCTReAFVHHnylKE72MOhVA4KKAGKPKpYhChwnK/cY5KcsSGPv83Nfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776259024; c=relaxed/simple; bh=NcD8HrOFIU/O8XtL7zx8dhkYVdR5EQZuUfSAbhUtad8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ceM76j6lse+6tvGWgIKwVEIF3o2+CEvu+gkBplMgnOP9utvGIyfw10WJJeQRMgrsZd8BE1MlpGR/BWLFZSj5YBAvdHg5o1zYNCVFUIZezE7zcjhroSTNaDhaI0d3yhweVWObGjQ/jdJ9XRWake4FLLn8JBvn6V+Wlt6+dB+IGlI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 890844BA2E07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776259024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKvf5MpWieIfHQl4jGbrXdvAQvm18OmGY3J6Ive2zUY=; b=fDhpQIZMl1uPBnVNSac46n1karI0prIjeNy4KloFPiNJLS3V9g3JRTfjUmOuU7xVzTrBci 5ZHwhNjUjDo6U1piUI9hyV0FNCOzJ1sUloDSs0C1XvILNCOl633mAiqhbugHVWQfvT4qYn fjwGlsWLnrbshnFC/NHCltZCkVc078E= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-388-ghl97LuUPcqrg8p46Du_ww-1; Wed, 15 Apr 2026 09:17:03 -0400 X-MC-Unique: ghl97LuUPcqrg8p46Du_ww-1 X-Mimecast-MFC-AGG-ID: ghl97LuUPcqrg8p46Du_ww_1776259023 Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-56f6c1b294fso5981612e0c.0 for ; Wed, 15 Apr 2026 06:17:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776259022; x=1776863822; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SKvf5MpWieIfHQl4jGbrXdvAQvm18OmGY3J6Ive2zUY=; b=CfhGS9zl7z/2EeNAlB1nwlyZp5QBhDsrlywm8B+2i6jCi6tU9Qi/7EdCrYWyLB6Eh0 0s5pZiluQGvtrxRUmeq4lw3maRBQ0YXNXu86PHe8eXSfLzca30OEEnrLptXetstSl+Ip 9UQoCmZ7uz8fd2I/F8SXQOMoYUVBWwrgALEqJMQNdjK23J1UWzx4q8hPFIP3SRvuUk8X 3PVFf34r40qdRG6UqAlYE1Lde8gUt2rgSdCWJMiBLmGKIGMD/DzZNokWQKZW/MBKyXi7 7jhIVnUpJSfS0DNSg/53CfQZM+AIO8LznYi+uH1x42EzsxET1g39PZFwUzFSEJaGl9yq sLqA== X-Gm-Message-State: AOJu0YwP7Y02LMSy+WOOEaXDVx1C6D8O8QGcNAHcZVr2LxGwazwLEjgH zl2FpbfaDSsNTXQNbtV4anyuOBjDm+yDYmQT6aC0gw1nvrnUx1tqir4ImRrefxqDD1Xlsn0FeEO dSTiITkRoFUOyUDR35RMXPsw7qC5PeUpzSk74CIpDmkShbjgaDMwl8QxsZkhJss5CvOF8AGA= X-Gm-Gg: AeBDiev0JVUPIJxhggB3IHLubk0ErGaFnIsoY3V+sl99UBqbJEH2orGbQdF0GE+qQm1 Ug/tCIvP9FcGLx/Kg7uUV91K0sTMKvSXMwKKYqZqMeiyVKgPtp+Ml1xn5ZhdMawI3jxooOxWnqm l/fJEPgGtreWM88731C9lr5e6/uKu5GgdBk5IbBf+bQj7MOb2Keeub43WtR/xreUpYWa6ZPXxEt CtsBEEUGbYiyYehsvBFwFd292EcPDMCyp2AraBRN0U7yCDgYcy961xZLyTInxMsO1SDcJ2dpo8k XnYgrut1j3mTLlnXwviWoSHP6IysTRoTAq0BD88vQpNCkOWXW09NjhgSi5RURI6CvaRO3qY1lVx 1xb01m2hxbyI8RNb83R9os53fPgYeG40= X-Received: by 2002:a05:6122:82a9:b0:56d:3451:4cc0 with SMTP id 71dfb90a1353d-56f3cafbba3mr7144189e0c.7.1776259014916; Wed, 15 Apr 2026 06:16:54 -0700 (PDT) X-Received: by 2002:a05:6122:82a9:b0:56d:3451:4cc0 with SMTP id 71dfb90a1353d-56f3cafbba3mr7143734e0c.7.1776259011036; Wed, 15 Apr 2026 06:16:51 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95864f494dasm734605241.0.2026.04.15.06.16.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 06:16:49 -0700 (PDT) Message-ID: <2c613de1-5671-4f20-95a8-e43413dd808e@redhat.com> Date: Wed, 15 Apr 2026 10:16:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] gdb: Introduce RAII signal handler setter To: "Aktemur, Tankut Baris" Cc: "gdb-patches@sourceware.org" , Tom Tromey References: <20241118195717.783180-1-guinevere@redhat.com> <87iksfs1pd.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 51KVGpry1XPTSIVbo35NisZ87lfHwsccB6KVPgfBDqw_1776259023 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/15/26 10:10 AM, Aktemur, Tankut Baris wrote: > Hi Guinevere, > > On Friday, November 22, 2024 6:51 PM, Guinevere Larsen wrote: >> On 11/22/24 12:55 PM, Tom Tromey wrote: >>>>>>>> "Guinevere" == Guinevere Larsen writes: >>> Guinevere> +#if defined (HAVE_SIGACTION) >>> Guinevere> + struct sigaction m_prev_handler; >>> Guinevere> +#else >>> Guinevere> + typedef sighandler_t m_prev_handler; >>> Guinevere> +#endif >>> >>> That #else branch looks wrong, I would guess s/typedef// >> gah! thanks, copy-paste issues. will fix >>> gnulib says sigaction isn't on mingw, so maybe a mingw cross-hosted >>> build would show the problem. >> I have un-defined the macro and tested. > Could it be that the local experiment above sneaked into > gdbsupport/scoped_signal_handler.h? In that file there is > > #undef HAVE_SIGACTION > > which seems to clear the macro unintentionally. oops, yes, it probably sneaked in. The file definitely was not supposed to be unsetting the macro. > > Regards, > -Baris > > > Intel Deutschland GmbH > Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany > Tel: +49 89 991 430, www.intel.de > Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell > Chairperson of the Supervisory Board: Nicole Lau > Registered Seat: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > -- Cheers, Guinevere Larsen It/she