From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id y0ePDvvEQGe0KTsAWB0awg (envelope-from ) for ; Fri, 22 Nov 2024 12:52:59 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=isiLstDP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1F9A31E25F; Fri, 22 Nov 2024 12:52:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7F7791E1CC for ; Fri, 22 Nov 2024 12:52:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F3E8E385B50B for ; Fri, 22 Nov 2024 17:52:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3E8E385B50B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=isiLstDP Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 355903856946 for ; Fri, 22 Nov 2024 17:50:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 355903856946 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 355903856946 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732297859; cv=none; b=oqmU9svnyHBDqy1lX3WsP564Uc2LxVL0u0tGYHHVR3bn9lWdDld9lhUuVi8WRt+4aBnGM5MiXSHXy1OMbz5anaG6WVfFuGljWjDP/hsBYYdhwjHY9w8R73ndhSQqppN+nSFYDOy4BsaUNa52HADQbAT0URH8oatauf3f5z945Xo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732297859; c=relaxed/simple; bh=IGeOGMy9NMB9tH6Auy4bX6sFgP5DMTg1Zgs/Hhi2NXY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tm8qDCbIt3Ie651Wac66wO8vDNDa1yFEw6mo/1AKqv5xIjMv1ObEcwrtD+At9cEhhtGuxT2BhLcgnCAy+ZgnD3wx9i7XQEXB1UEwSS4MyRwjDz3PtIP0lwb4SQzfSzT/oDW8VER6E9LClLHo8uiGse5u7HxymcZcdPEstUmT1fA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 355903856946 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732297858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rRLunrzENqAq98DBKWCTTWpaQIVAA22HromaIzJ5q8M=; b=isiLstDPZ+5etvmo0n3ezoauBCWma1A25wmoJADeqvOxyaakF/rbEYejP75/t5eVTOtcE6 fYRpSJa+c1U4vLGNa69wGT7QYl14W7GOyVydE4Xc4KmkvGlGAwL8RaajBgW7ZTafcZf14z CFp6sy3/t8wFeGqywVEtWcB04UNbmEo= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-3WJXZFw3N4a9R3EsWFW1Bw-1; Fri, 22 Nov 2024 12:50:57 -0500 X-MC-Unique: 3WJXZFw3N4a9R3EsWFW1Bw-1 X-Mimecast-MFC-AGG-ID: 3WJXZFw3N4a9R3EsWFW1Bw Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7b163e0a5ecso298747885a.1 for ; Fri, 22 Nov 2024 09:50:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732297857; x=1732902657; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rRLunrzENqAq98DBKWCTTWpaQIVAA22HromaIzJ5q8M=; b=k+JiTM5KxvovmmXZBlhsHHxXXvz38TOVxNrimQTjyLXhN78IsPHqJ6cO9MyaCmvkIw jM/mmwYUc/YwtbexWWylqT8uz7MaAhVaWQ/YX5VzvnbsIdaRoxBY7Jy54aPrOkxc21nf 4Nc1sxZiKNYPzSeIToGY5vBHwqjp4TTYxCpv+rGGDIf4MEuWetvNzc3xi3VOeHsUJlRC CZQJp/fM/di8lZu03K8BtHvx6ZSMg/lwPZGwiyXAXhfCb4Nboh2VHp2YCYmfF8FZjvAU dT8SX4byh3q6KymsU7/KkbKhxgpULke+A0whINlWgNjNDHKAdT174I66Xkl+mzH77E8G iYDQ== X-Gm-Message-State: AOJu0Yz/x6ig9p/BYEcVM/R6vAd6fTHJ30WrLVJXr5hgqiHJ7mTh9ZpW HqWHfX/dUQZSkNfHpSXgWNxb9aSqXg4WEyQR7DmdZYftE/Gnj+m2UA2v2yOOr32l1GihL0bZLRG WDA5bgVvzLnUFyJDzGjNvcE3SZfgEc4DfJP6ONDmA7wclL5Fc8dyLmcYxDoHFSUYe8+0= X-Gm-Gg: ASbGncvUUPzcOZc+obcFCMC3qfe4/GB9WSRZB0Y8FhbcOviHFHa9xeoU4Dg+x+7Ca/e iXhoQEUomYTe+n2j+i1xHU7lR45tRcV3XUCIrhx82B++i803I7Ip5oS5Jp0cZyI+o3P4dAq1kek DzxmQD1NEJaOHLhIHccvDEtVXtVLsBbDan+N7bF4J1OGNJ/AsCu80+hWb+Cpa6J2Wf7DWFq1BNe 9qohWy8yHTmP+O9zkl+OEyDo7up7RHviBy9tYP8IvmTKHx+7nOpJKd2v1qUXw== X-Received: by 2002:a05:620a:404f:b0:7af:c5ee:bc42 with SMTP id af79cd13be357-7b514643444mr406014385a.50.1732297857298; Fri, 22 Nov 2024 09:50:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IH2RNZtygW0AlWwW9uhP9yiwG42t2PmK+RH0WZfYBuqg5t+p3IL6nZ1efbKxdKke+LwFJFRsg== X-Received: by 2002:a05:620a:404f:b0:7af:c5ee:bc42 with SMTP id af79cd13be357-7b514643444mr406013285a.50.1732297857032; Fri, 22 Nov 2024 09:50:57 -0800 (PST) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b51418b0b7sm107234085a.126.2024.11.22.09.50.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2024 09:50:56 -0800 (PST) Message-ID: Date: Fri, 22 Nov 2024 14:50:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] gdb: Introduce RAII signal handler setter To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20241118195717.783180-1-guinevere@redhat.com> <87iksfs1pd.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87iksfs1pd.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Fg3u3wFb74jVjdoGxzP6C3cB2Cg0sonMwOrmHEc1lNo_1732297857 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/22/24 12:55 PM, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> +#if defined (HAVE_SIGACTION) > Guinevere> + struct sigaction m_prev_handler; > Guinevere> +#else > Guinevere> + typedef sighandler_t m_prev_handler; > Guinevere> +#endif > > That #else branch looks wrong, I would guess s/typedef// gah! thanks, copy-paste issues. will fix > > gnulib says sigaction isn't on mingw, so maybe a mingw cross-hosted > build would show the problem. I have un-defined the macro and tested. Current version did fail to build and changing that line has fixed compilation. -- Cheers, Guinevere Larsen She/Her/Hers > > Tom >