Re: [PATCH v2 7/8] gdb: Fully remove stabs code from GDB

[Guinevere Larsen <guinevere@redhat.com>]

On 10/20/25 1:39 PM, Eli Zaretskii wrote:
>> From: Guinevere Larsen <guinevere@redhat.com>
>> Cc: Guinevere Larsen <guinevere@redhat.com>,
>> 	Tom Tromey <tom@tromey.com>
>> Date: Mon, 20 Oct 2025 12:28:51 -0300
>>
>> This commit is the last in the series removing GDB's support for stabs.
>> It removes the stabsread.{c|h} files, and removes the last usage of
>> stabsread stuff in buildsym.  Notably, the header file gdb-stabs.h
>> remains in the tree as it is misnamed at this point - it is used for
>> reading dbx objfiles.  It (and dbxread) will be removed in a future
>> commit.
>>
>> Approved-By: Tom Tromey <tom@tromey.com>
>> ---
>>   gdb/Makefile.in                      |    2 -
>>   gdb/NEWS                             |    2 +
>>   gdb/arch-utils.c                     |    6 -
>>   gdb/arch-utils.h                     |    3 -
>>   gdb/buildsym.c                       |   18 -
>>   gdb/dbxread.c                        |    9 +
>>   gdb/doc/Makefile.in                  |   46 +-
>>   gdb/doc/gdb.texinfo                  |   23 +-
>>   gdb/doc/stabs.texinfo                | 4130 ---------------
>>   gdb/gdbarch-gen.c                    |   22 -
>>   gdb/gdbarch-gen.h                    |    4 -
>>   gdb/gdbarch_components.py            |    8 -
>>   gdb/microblaze-tdep.c                |    8 -
>>   gdb/objfiles.h                       |    3 -
>>   gdb/sparc-tdep.c                     |   10 -
>>   gdb/sparc64-tdep.c                   |    2 -
>>   gdb/stabsread.c                      | 7209 --------------------------
>>   gdb/stabsread.h                      |  309 --
>>   gdb/symmisc.c                        |    3 -
>>   gdb/testsuite/gdb.stabs/aout.sed     |   16 -
>>   gdb/testsuite/gdb.stabs/ecoff.sed    |   17 -
>>   gdb/testsuite/gdb.stabs/exclfwd.exp  |   57 -
>>   gdb/testsuite/gdb.stabs/exclfwd.h    |   21 -
>>   gdb/testsuite/gdb.stabs/exclfwd1.c   |   34 -
>>   gdb/testsuite/gdb.stabs/exclfwd2.c   |   29 -
>>   gdb/testsuite/gdb.stabs/gdb11479.c   |   76 -
>>   gdb/testsuite/gdb.stabs/gdb11479.exp |   59 -
>>   gdb/testsuite/gdb.stabs/hppa.sed     |   20 -
>>   gdb/testsuite/gdb.stabs/weird.def    |  900 ----
>>   gdb/testsuite/gdb.stabs/xcoff.sed    |   17 -
>>   30 files changed, 27 insertions(+), 13036 deletions(-)
>>   delete mode 100644 gdb/doc/stabs.texinfo
>>   delete mode 100644 gdb/stabsread.c
>>   delete mode 100644 gdb/stabsread.h
>>   delete mode 100644 gdb/testsuite/gdb.stabs/aout.sed
>>   delete mode 100644 gdb/testsuite/gdb.stabs/ecoff.sed
>>   delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd.exp
>>   delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd.h
>>   delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd1.c
>>   delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd2.c
>>   delete mode 100644 gdb/testsuite/gdb.stabs/gdb11479.c
>>   delete mode 100644 gdb/testsuite/gdb.stabs/gdb11479.exp
>>   delete mode 100644 gdb/testsuite/gdb.stabs/hppa.sed
>>   delete mode 100644 gdb/testsuite/gdb.stabs/weird.def
>>   delete mode 100644 gdb/testsuite/gdb.stabs/xcoff.sed
> Thanks, but didn't I already approve the documentation parts of this?
> They are almost entirely trivial anyway.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>
You're right, I must've forgotten to add your tag. Sorry about that

-- 
Cheers,
Guinevere Larsen
It/she