From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0XAhAtOJ9mgrkAAAWB0awg (envelope-from ) for ; Mon, 20 Oct 2025 15:13:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=E6JhouXw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0574E1E0BC; Mon, 20 Oct 2025 15:13:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 605621E047 for ; Mon, 20 Oct 2025 15:13:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 03BCC3858D29 for ; Mon, 20 Oct 2025 19:13:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 03BCC3858D29 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=E6JhouXw Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id D63393858D21 for ; Mon, 20 Oct 2025 19:12:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D63393858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D63393858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760987535; cv=none; b=pUfbFWSv2YiWt6h3SLPFjdFn8CVn+MQb1JUU++6FNuJx/q9ty6QIiXqljGT6ez3x9arPfD5xh0uf0XesFib4fwex0HYpZwBHqWWom7an3rZU7kBsyo0Fhe1XLhfseE6v2len9RSCMwGqMxmCRKR7mKdx01tyYXbcry/fRjjF744= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760987535; c=relaxed/simple; bh=wwENCnIFYlTWg3wctW29uPRkhBrEF3ijAj/mkNNizow=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DvGA54x5z8VGCBgYp0XQHamSm/v+8H+KBGuf14cyAP98JZ8NU2Q4g5BSsQ9c6TuiPbU3Uoo+Bce8YneZpf8JPXWrrVLLzzWReK/NjOiN8aayzN480RueEjw3CxBvxeIxfMxuvifb5IBxGVID+MuRik7KdQ281IrAx2POCF9layE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D63393858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760987535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nz3PsJGAaobFdWPT32Z99NV+QzIxqoaBX0JL+0IBEn4=; b=E6JhouXwv99MuvXlh0Eu5JXY56tkwuhfVnDFQJrNhbio5rORboSX988YiwMRKS36esNgYU H/GpqPhd14Ub2RqDuJupJfFCJEzyLPkB9hXpUjH4OZW1fBIOGtN2vM1FvMtXMM8T9zjET2 t+46TZFUsnqT7waFRQGVzgTNfx6Tc+0= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-R1tjKpgFNSmRmFGSVVOsTw-1; Mon, 20 Oct 2025 15:12:14 -0400 X-MC-Unique: R1tjKpgFNSmRmFGSVVOsTw-1 X-Mimecast-MFC-AGG-ID: R1tjKpgFNSmRmFGSVVOsTw_1760987533 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-781269a9049so8115243b3a.2 for ; Mon, 20 Oct 2025 12:12:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760987526; x=1761592326; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nz3PsJGAaobFdWPT32Z99NV+QzIxqoaBX0JL+0IBEn4=; b=L6i7B+yH54lUompO15AqDOrATDeTA2lTjm9K5e6KVh0LTJWUtG5eozEKGMGTfEf8a1 hi2Fb7cB86vIwpYNHXwx+OvOA9asfB2oRXM4ER0VKwWJ6RrD5d+iamknFQ7bHYbSzeuA hJrR0k51iy/zei4Sr8mv7UWJ0Or4/667D8YqRMBfHf8VV1/diwfpoIckCKGquqCvoox3 qJiN6dZjNhjZaVwRhN15IqjX5wt+0t56fddNy6lrL18wmE75pnahmSV4MMGRa/ljXUHd bkEl2GdIlgRzCju6qb1r5yF7m6A46lN1vbgxheSzbEuIDrTDU8mHhtLNghn/MZHanNCE eHMw== X-Gm-Message-State: AOJu0Yzx0eqL6d4TDqHN5JebhttXgjChxYWGErlQHLdGW3riskAAN3EQ VANrGDOT3YXHuvc6rfdxOeqbwWffwVK3beQ88u24Zjds/HrZ5NrsGJ4bMRLDPP0WMqhMQb8YYMp 6enORFo4uhRaB5CbVdHA4HL/F75gfap3yJ4mLvYnqFDLwLbak4IMK7fB9bX6fkr8m5NJ+yc0= X-Gm-Gg: ASbGnct6wjqtdKRes+Khs1b0GeTHG3b6JHwxcGwxIEQQnq0hDuAbB6aS19SDTi+GFSA HavOSKXCJdSeh+d/JRL93bxLSWkw6welO/b+RiHJS6KJLlRU3vbZDBMkPVASONCzjqRZFHUlclv fuHqwmccfiOzPkUuqHa9z+O43p5b41bgMXIzZ8APhBR5dso8nDxjiXCyGqr5tdCs1W1Vo2YZLZD 037fRv/zMpmutgUqYureI0yuMKCsSfz1THEyJ3J0rHxLkGgV2lefzodw/A7n8TAparEPzN1eFJS Zr0CzownS8BGvnHQf8Rh7yfAZxSDl23lgQNx4Kit+W8b6FyQnmRolIiUAN98tQcacCah7lmRPCR aPv0v+2SJbgY= X-Received: by 2002:a05:6a00:4f88:b0:78a:f784:e8cf with SMTP id d2e1a72fcca58-7a220d42784mr15596979b3a.27.1760987526465; Mon, 20 Oct 2025 12:12:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFcnf8sF2yMbxxtuKEDQVaZMuhwSCW6RloKGDWNp9zCn7vNPbmhnMV4ZoGFVMIAqeIhP9AYA== X-Received: by 2002:a05:6a00:4f88:b0:78a:f784:e8cf with SMTP id d2e1a72fcca58-7a220d42784mr15596953b3a.27.1760987526095; Mon, 20 Oct 2025 12:12:06 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a230121ed6sm8972091b3a.73.2025.10.20.12.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 12:12:05 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 16:12:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/8] gdb: Fully remove stabs code from GDB To: Eli Zaretskii Cc: gdb-patches@sourceware.org, tom@tromey.com References: <20251020152853.28195-1-guinevere@redhat.com> <20251020152853.28195-8-guinevere@redhat.com> <865xc9y1cg.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <865xc9y1cg.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xjeOz7lN7DnwK5fik9BX_O_fBsKh5tVWh9gDzB3Vk3Y_1760987533 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/20/25 1:39 PM, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: Guinevere Larsen , >> Tom Tromey >> Date: Mon, 20 Oct 2025 12:28:51 -0300 >> >> This commit is the last in the series removing GDB's support for stabs. >> It removes the stabsread.{c|h} files, and removes the last usage of >> stabsread stuff in buildsym. Notably, the header file gdb-stabs.h >> remains in the tree as it is misnamed at this point - it is used for >> reading dbx objfiles. It (and dbxread) will be removed in a future >> commit. >> >> Approved-By: Tom Tromey >> --- >> gdb/Makefile.in | 2 - >> gdb/NEWS | 2 + >> gdb/arch-utils.c | 6 - >> gdb/arch-utils.h | 3 - >> gdb/buildsym.c | 18 - >> gdb/dbxread.c | 9 + >> gdb/doc/Makefile.in | 46 +- >> gdb/doc/gdb.texinfo | 23 +- >> gdb/doc/stabs.texinfo | 4130 --------------- >> gdb/gdbarch-gen.c | 22 - >> gdb/gdbarch-gen.h | 4 - >> gdb/gdbarch_components.py | 8 - >> gdb/microblaze-tdep.c | 8 - >> gdb/objfiles.h | 3 - >> gdb/sparc-tdep.c | 10 - >> gdb/sparc64-tdep.c | 2 - >> gdb/stabsread.c | 7209 -------------------------- >> gdb/stabsread.h | 309 -- >> gdb/symmisc.c | 3 - >> gdb/testsuite/gdb.stabs/aout.sed | 16 - >> gdb/testsuite/gdb.stabs/ecoff.sed | 17 - >> gdb/testsuite/gdb.stabs/exclfwd.exp | 57 - >> gdb/testsuite/gdb.stabs/exclfwd.h | 21 - >> gdb/testsuite/gdb.stabs/exclfwd1.c | 34 - >> gdb/testsuite/gdb.stabs/exclfwd2.c | 29 - >> gdb/testsuite/gdb.stabs/gdb11479.c | 76 - >> gdb/testsuite/gdb.stabs/gdb11479.exp | 59 - >> gdb/testsuite/gdb.stabs/hppa.sed | 20 - >> gdb/testsuite/gdb.stabs/weird.def | 900 ---- >> gdb/testsuite/gdb.stabs/xcoff.sed | 17 - >> 30 files changed, 27 insertions(+), 13036 deletions(-) >> delete mode 100644 gdb/doc/stabs.texinfo >> delete mode 100644 gdb/stabsread.c >> delete mode 100644 gdb/stabsread.h >> delete mode 100644 gdb/testsuite/gdb.stabs/aout.sed >> delete mode 100644 gdb/testsuite/gdb.stabs/ecoff.sed >> delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd.exp >> delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd.h >> delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd1.c >> delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd2.c >> delete mode 100644 gdb/testsuite/gdb.stabs/gdb11479.c >> delete mode 100644 gdb/testsuite/gdb.stabs/gdb11479.exp >> delete mode 100644 gdb/testsuite/gdb.stabs/hppa.sed >> delete mode 100644 gdb/testsuite/gdb.stabs/weird.def >> delete mode 100644 gdb/testsuite/gdb.stabs/xcoff.sed > Thanks, but didn't I already approve the documentation parts of this? > They are almost entirely trivial anyway. > > Reviewed-By: Eli Zaretskii > You're right, I must've forgotten to add your tag. Sorry about that -- Cheers, Guinevere Larsen It/she