Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCH v2 7/8] gdb: Fully remove stabs code from GDB
Date: Mon, 20 Oct 2025 19:39:11 +0300	[thread overview]
Message-ID: <865xc9y1cg.fsf@gnu.org> (raw)
In-Reply-To: <20251020152853.28195-8-guinevere@redhat.com> (message from Guinevere Larsen on Mon, 20 Oct 2025 12:28:51 -0300)

> From: Guinevere Larsen <guinevere@redhat.com>
> Cc: Guinevere Larsen <guinevere@redhat.com>,
> 	Tom Tromey <tom@tromey.com>
> Date: Mon, 20 Oct 2025 12:28:51 -0300
> 
> This commit is the last in the series removing GDB's support for stabs.
> It removes the stabsread.{c|h} files, and removes the last usage of
> stabsread stuff in buildsym.  Notably, the header file gdb-stabs.h
> remains in the tree as it is misnamed at this point - it is used for
> reading dbx objfiles.  It (and dbxread) will be removed in a future
> commit.
> 
> Approved-By: Tom Tromey <tom@tromey.com>
> ---
>  gdb/Makefile.in                      |    2 -
>  gdb/NEWS                             |    2 +
>  gdb/arch-utils.c                     |    6 -
>  gdb/arch-utils.h                     |    3 -
>  gdb/buildsym.c                       |   18 -
>  gdb/dbxread.c                        |    9 +
>  gdb/doc/Makefile.in                  |   46 +-
>  gdb/doc/gdb.texinfo                  |   23 +-
>  gdb/doc/stabs.texinfo                | 4130 ---------------
>  gdb/gdbarch-gen.c                    |   22 -
>  gdb/gdbarch-gen.h                    |    4 -
>  gdb/gdbarch_components.py            |    8 -
>  gdb/microblaze-tdep.c                |    8 -
>  gdb/objfiles.h                       |    3 -
>  gdb/sparc-tdep.c                     |   10 -
>  gdb/sparc64-tdep.c                   |    2 -
>  gdb/stabsread.c                      | 7209 --------------------------
>  gdb/stabsread.h                      |  309 --
>  gdb/symmisc.c                        |    3 -
>  gdb/testsuite/gdb.stabs/aout.sed     |   16 -
>  gdb/testsuite/gdb.stabs/ecoff.sed    |   17 -
>  gdb/testsuite/gdb.stabs/exclfwd.exp  |   57 -
>  gdb/testsuite/gdb.stabs/exclfwd.h    |   21 -
>  gdb/testsuite/gdb.stabs/exclfwd1.c   |   34 -
>  gdb/testsuite/gdb.stabs/exclfwd2.c   |   29 -
>  gdb/testsuite/gdb.stabs/gdb11479.c   |   76 -
>  gdb/testsuite/gdb.stabs/gdb11479.exp |   59 -
>  gdb/testsuite/gdb.stabs/hppa.sed     |   20 -
>  gdb/testsuite/gdb.stabs/weird.def    |  900 ----
>  gdb/testsuite/gdb.stabs/xcoff.sed    |   17 -
>  30 files changed, 27 insertions(+), 13036 deletions(-)
>  delete mode 100644 gdb/doc/stabs.texinfo
>  delete mode 100644 gdb/stabsread.c
>  delete mode 100644 gdb/stabsread.h
>  delete mode 100644 gdb/testsuite/gdb.stabs/aout.sed
>  delete mode 100644 gdb/testsuite/gdb.stabs/ecoff.sed
>  delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd.exp
>  delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd.h
>  delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd1.c
>  delete mode 100644 gdb/testsuite/gdb.stabs/exclfwd2.c
>  delete mode 100644 gdb/testsuite/gdb.stabs/gdb11479.c
>  delete mode 100644 gdb/testsuite/gdb.stabs/gdb11479.exp
>  delete mode 100644 gdb/testsuite/gdb.stabs/hppa.sed
>  delete mode 100644 gdb/testsuite/gdb.stabs/weird.def
>  delete mode 100644 gdb/testsuite/gdb.stabs/xcoff.sed

Thanks, but didn't I already approve the documentation parts of this?
They are almost entirely trivial anyway.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2025-10-20 16:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 15:28 [PATCH v2 0/8] Remove stabs support " Guinevere Larsen
2025-10-20 15:28 ` [PATCH v2 1/8] gdb: move some stabs functions to gdb/buildsym-legacy.h Guinevere Larsen
2025-10-20 16:25   ` Tom Tromey
2025-10-20 15:28 ` [PATCH v2 2/8] gdb/mdebug: Remove stabs support from mips inferiors Guinevere Larsen
2025-10-20 15:28 ` [PATCH v2 3/8] gdb: Remove stabs support from ELF files Guinevere Larsen
2025-10-20 15:28 ` [PATCH v2 4/8] gdb: Remove stabs support from dbx Guinevere Larsen
2025-10-20 15:28 ` [PATCH v2 5/8] gdb: Remove stabs support for COFF files Guinevere Larsen
2025-10-20 15:28 ` [PATCH v2 6/8] gdb: Remove stabs support from XCOFF inferiors Guinevere Larsen
2025-11-07 10:46   ` Andrew Burgess
2025-11-07 12:09     ` Guinevere Larsen
2025-11-07 14:46       ` Tom Tromey
2025-10-20 15:28 ` [PATCH v2 7/8] gdb: Fully remove stabs code from GDB Guinevere Larsen
2025-10-20 16:39   ` Eli Zaretskii [this message]
2025-10-20 19:12     ` Guinevere Larsen
2025-10-20 15:28 ` [PATCH v2 8/8] gdb: remove support for dbx " Guinevere Larsen
2025-10-21 19:14 ` [PATCH v2 0/8] Remove stabs support " Tom Tromey
2025-10-21 19:42   ` Guinevere Larsen
2025-10-22  9:48 ` Luis
2025-10-22 13:08   ` Tom Tromey
2025-10-22 13:19     ` Guinevere Larsen
2025-10-22 19:19       ` Luis
2025-10-23  0:58         ` Luis
2025-10-23  2:03           ` Andrew Pinski
2025-10-23 18:11 ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xc9y1cg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox