Re: [PATCH 2/2] [gdb/testsuite] Make gdb.threads/inf-thr-count.exp more readable

[Tom de Vries <tdevries@suse.de>]

On 4/18/25 11:39, Andreas Schwab wrote:
> On Apr 18 2025, Tom de Vries wrote:
> 
>> +    set re_int [string_to_regexp "-"]?$::decimal
> 
> Why do you need to use string_to_regexp for such a simple string?
> 

Hi Andreas,

thanks for the review.

Indeed, [string_to_regexp "-"] == "-", I didn't realize that.

I guess that using {[-]} comes from problems when using the minus at the 
start of a regexp:
...
% puts [regexp {-} {-}]
bad option "-": must be -all, -about, -indices, -inline, -expanded, 
-line, -linestop, -lineanchor, -nocase, -start, or --
% puts [regexp {[-]} {-}]
1
%
...
while this also works:
...
% puts [regexp {\-} {-}]
1
...

So perhaps string_to_regexp should also escape "-" to fix this failure:
...
set re [string_to_regexp "-"]
gdb_assert { [eval regexp $re "-"] }
...

Thanks,
- Tom