From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bKJ/ILQtAmi3wjkAWB0awg (envelope-from ) for ; Fri, 18 Apr 2025 06:47:16 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zfBLyz16; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6qv5MmQj; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zfBLyz16; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6qv5MmQj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6F8C71E0C3; Fri, 18 Apr 2025 06:47:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8A99D1E0C0 for ; Fri, 18 Apr 2025 06:47:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 157FA3857007 for ; Fri, 18 Apr 2025 10:47:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 157FA3857007 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zfBLyz16; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6qv5MmQj; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zfBLyz16; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6qv5MmQj Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id D62DA3858D20 for ; Fri, 18 Apr 2025 10:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D62DA3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D62DA3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744973203; cv=none; b=YDowxXMiGvoaT7yM5PhjVzxYRr0EOaiF5ZjOa08eBacAtkqbrkZeJEu8PFnF+fWyyrC9KnlXPwv+XAlQNMrowCJC8Clf8QMD9NMY/BOE3t4A10evLgmlIoWG0ZW3kdrCTxPeU/RdNt9LgMidziA9VKbeupCEZjPPCMmA4mBmyKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744973203; c=relaxed/simple; bh=1FU00JFhkXZ5p8nESZVuoDKHczXBFjvjw0FEQzhGtHU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=TYDt3ymdfqnY1GHRtoU5K+Wc1f118oSn6vHlEA+IIvX13qwC+Wm2y5kf+773ZKDmnB/bpnMirOtXreBDab12XQv4RyFYSyG7NR88rzqwmS+SEI46gurEAGWlqgJwVdYrYRTKW7wte7vbD2QnzxuZOvQLfXcNRHDo/AUxwLNDHCM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D62DA3858D20 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1FE26211CA; Fri, 18 Apr 2025 10:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744973200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sj1vf0t8Pjr0IN7aOUw3hOv6SDr2BWQFLe3qbydPCxg=; b=zfBLyz16JTcpPFHlxGonsgJbQsiz99OBtJ0bJEMBnDqvMNTsaerZh7u16ksrn0SjFFjBzB vkR7kmVaB88c5QQaaGGvNx8JFLb7gJfgIffUSfvHiL/+6Ny8ezIxd1wGng+4+JTAbNXZP9 42P8p6jByok/XANBYooROllGHma0ajM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744973200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sj1vf0t8Pjr0IN7aOUw3hOv6SDr2BWQFLe3qbydPCxg=; b=6qv5MmQjNjkdki5OZXFIS51HylqgQH+0zJliF1EQUxAyIiEH+Bbni4Auhz3D5wvktfUuUJ A6IxP50iZL85h7Aw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zfBLyz16; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6qv5MmQj DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744973200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sj1vf0t8Pjr0IN7aOUw3hOv6SDr2BWQFLe3qbydPCxg=; b=zfBLyz16JTcpPFHlxGonsgJbQsiz99OBtJ0bJEMBnDqvMNTsaerZh7u16ksrn0SjFFjBzB vkR7kmVaB88c5QQaaGGvNx8JFLb7gJfgIffUSfvHiL/+6Ny8ezIxd1wGng+4+JTAbNXZP9 42P8p6jByok/XANBYooROllGHma0ajM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744973200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sj1vf0t8Pjr0IN7aOUw3hOv6SDr2BWQFLe3qbydPCxg=; b=6qv5MmQjNjkdki5OZXFIS51HylqgQH+0zJliF1EQUxAyIiEH+Bbni4Auhz3D5wvktfUuUJ A6IxP50iZL85h7Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F082013942; Fri, 18 Apr 2025 10:46:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id osilNo8tAmhjMAAAD6G6ig (envelope-from ); Fri, 18 Apr 2025 10:46:39 +0000 Message-ID: Date: Fri, 18 Apr 2025 12:47:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Make gdb.threads/inf-thr-count.exp more readable To: Andreas Schwab Cc: gdb-patches@sourceware.org References: <20250418092356.4579-1-tdevries@suse.de> <20250418092356.4579-3-tdevries@suse.de> <87r01pg655.fsf@linux-m68k.org> Content-Language: en-US From: Tom de Vries In-Reply-To: <87r01pg655.fsf@linux-m68k.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1FE26211CA X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/18/25 11:39, Andreas Schwab wrote: > On Apr 18 2025, Tom de Vries wrote: > >> + set re_int [string_to_regexp "-"]?$::decimal > > Why do you need to use string_to_regexp for such a simple string? > Hi Andreas, thanks for the review. Indeed, [string_to_regexp "-"] == "-", I didn't realize that. I guess that using {[-]} comes from problems when using the minus at the start of a regexp: ... % puts [regexp {-} {-}] bad option "-": must be -all, -about, -indices, -inline, -expanded, -line, -linestop, -lineanchor, -nocase, -start, or -- % puts [regexp {[-]} {-}] 1 % ... while this also works: ... % puts [regexp {\-} {-}] 1 ... So perhaps string_to_regexp should also escape "-" to fix this failure: ... set re [string_to_regexp "-"] gdb_assert { [eval regexp $re "-"] } ... Thanks, - Tom