Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [gdb/testsuite] Make gdb.threads/inf-thr-count.exp more readable
Date: Fri, 2 May 2025 10:37:36 +0200	[thread overview]
Message-ID: <c0658783-4521-4720-a564-aa12d6bfc1a6@suse.de> (raw)
In-Reply-To: <871ptp9zmn.fsf@tromey.com>

On 4/18/25 18:57, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> So perhaps string_to_regexp should also escape "-" to fix this failure:
> Tom> ...
> Tom> set re [string_to_regexp "-"]
> Tom> gdb_assert { [eval regexp $re "-"] }
> Tom> ...
> 
> IMO it's better to use "--" to separate switches from arguments, like
> 
> regexp -- $re ...

Hi Tom,

I think you're right, but that knowledge may be lacking in someone 
trying to get their regexp to match.

Anyway, I'll drop the patch I proposed ( 
https://sourceware.org/pipermail/gdb-patches/2025-April/217279.html ) 
until someone seconds it, since it's in the not-strictly-necessary category.

Thanks,
- Tom

  reply	other threads:[~2025-05-02  8:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  9:23 [PATCH 0/2] [gdb/testsuite] Fixes in gdb.threads/inf-thr-count.exp Tom de Vries
2025-04-18  9:23 ` [PATCH 1/2] [gdb/testsuite] Fix timeout " Tom de Vries
2025-04-18  9:23 ` [PATCH 2/2] [gdb/testsuite] Make gdb.threads/inf-thr-count.exp more readable Tom de Vries
2025-04-18  9:39   ` Andreas Schwab
2025-04-18 10:47     ` Tom de Vries
2025-04-18 16:57       ` Tom Tromey
2025-05-02  8:37         ` Tom de Vries [this message]
2025-05-02  8:31       ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0658783-4521-4720-a564-aa12d6bfc1a6@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox