Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis <luis.machado.foss@gmail.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
	Srinath Parvathaneni <Srinath.Parvathaneni@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	"guinevere@redhat.com" <guinevere@redhat.com>,
	Ezra Sitorus <Ezra.Sitorus@arm.com>,
	Matthieu Longo <Matthieu.Longo@arm.com>,
	"simark@simark.ca" <simark@simark.ca>,
	Yury Khrustalev <Yury.Khrustalev@arm.com>
Subject: Re: [PATCH v3 1/5] [PATCH 1/5] gdb/aarch64: Add POR_EL0 register support for FEAT_S1POE
Date: Sat, 25 Jul 2026 08:29:03 +0100	[thread overview]
Message-ID: <f2748958-46b6-409f-8e67-4f843b1f6f37@gmail.com> (raw)
In-Reply-To: <87fr17lhpx.fsf@linaro.org>

Hi,

On 25/07/2026 07:13, Thiago Jung Bauermann wrote:
> Srinath Parvathaneni <Srinath.Parvathaneni@arm.com> writes:
> 
>>>> *  p/x $por_el0
>>>> *  set $por_el0 = <value>
>>>>
>>>> Example:
>>>> (gdb) info register por_el0
>>>> por_el0 0x7 [ P15=--- P14=--- P13=--- P12=--- P11=--- P10=--- P9=--- P8=--- P7=---
>> P6=--- P5=--- P4=--- P3=--- P2=--- P1=--- P0=rwx ]
>>>> (gdb) set $por_el0=0xffffffff77777777
>>>> (gdb) info register por_el0
>>>> por_el0 0xffffffff77777777 [ P15=??? P14=??? P13=??? P12=??? P11=??? P10=??? P9=???
>> P8=??? P7=rwx P6=rwx P5=rwx P4=rwx P3=rwx P2=rwx P1=rwx P0=rwx ]
>>>> (gdb) p $por_el0
>>>> $1 = [ P15=??? P14=??? P13=??? P12=??? P11=??? P10=??? P9=??? P8=??? P7=rwx P6=rwx
>> P5=rwx P4=rwx P3=rwx P2=rwx P1=rwx P0=rwx ]
>>>> (gdb) p/x $por_el0
>>>> $2 = 0xffffffff77777777
>>>> (gdb) set $por_el0=0x57
>>>> (gdb) info register por_el0
>>>> por_el0 0x57 [ P15=--- P14=--- P13=--- P12=--- P11=--- P10=--- P9=--- P8=--- P7=---
>> P6=--- P5=--- P4=--- P3=--- P2=--- P1=rw- P0=rwx ]
>>>> (gdb) set $por_el0=0xf7f7f7f7f7f7f7f7
>>>> (gdb) info register por_el0
>>>> por_el0 0xf7f7f7f7f7f7f7f7 [ P15=??? P14=rwx P13=??? P12=rwx P11=??? P10=rwx P9=???
>> P8=rwx P7=??? P6=rwx P5=??? P4=rwx P3=??? P2=rwx P1=??? P0=rwx ]
>>>> (gdb)
>>>
>>> Looking at the output above I think it is a bit hard to read.
> 
> I think part of the reason for it being hard to read is that the output
> is very wide.

Indeed. I mean, as an overview it's fine. But it really depends on the 
most common use case for this register.

What I want to steer clear from is something like we have for SVE 
registers. It is a barrage of text that isn´t very easy to use.

> 
> One way to address this is Srinath's suggestion below to not print
> zeroed keys. Another would be to improve the output of the flag type to
> add line breaks when the terminal's width is reached, as is done when
> printing array values.
> 
> Another option would be to use a struct rather than a flags type. Then
> there would be one type per field, and it would be possible to display
> (and set) only one key.
> 
> Not sure which of them I prefer. The struct idea has the advantage of
> letting the user easily set protection keys individually. OTOH it's
> not printed isn a very compact way.
> 
> If easily displaying/setting individual keys isn't that important, I
> think I slightly prefer not printing zeroed keys as Srinath suggests,
> possibly coupled with adding line breaks when the line is too long, to
> address the case of having many keys set in the register.
> 

Good suggestions. I'd say if users want...

- An overview with permissions, then print what we have above
- To use it as a mask, we should have the raw value
- To read/write individual P<x> entries within the register, then we 
should have pseudo-registers that map back to por_el0.

The pseudo registers would leave the interpretation of the raw values 
out of the XML, therefore remote stubs wouldn´t need to pass that sort 
of information.

Stretching it a little bit, remote stubs could even send a modified 
version of these fields in the XML and gdb would start printing 
something else.

  reply	other threads:[~2026-07-25  7:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 20:15 [PATCH v3 0/5] " srinath.parvathaneni
2026-07-14 20:15 ` [PATCH v3 1/5] [PATCH 1/5] " srinath.parvathaneni
2026-07-21 19:53   ` Luis
2026-07-25  6:20     ` Thiago Jung Bauermann
2026-07-25  7:37       ` Luis
2026-07-25 18:44         ` Thiago Jung Bauermann
2026-07-21 20:25   ` Luis
2026-07-23  9:29     ` Srinath Parvathaneni
2026-07-25  6:13       ` Thiago Jung Bauermann
2026-07-25  7:29         ` Luis [this message]
2026-07-14 20:15 ` [PATCH v3 2/5] [PATCH 2/5] gdb: Improve SIGSEGV diagnostics for POE faults srinath.parvathaneni
2026-07-21 20:30   ` Luis
2026-07-22  9:41     ` Matthieu Longo
2026-07-22 23:11       ` Luis
2026-07-23  9:03         ` Srinath Parvathaneni
2026-07-25  7:39           ` Luis
2026-07-14 20:15 ` [PATCH v3 3/5] [PATCH 3/5] gdbserver/aarch64: Add POR_EL0 register support srinath.parvathaneni
2026-07-14 20:15 ` [PATCH v3 4/5] [PATCH 4/5] gdb/aarch64: Add core file support for FEAT_S1POE srinath.parvathaneni
2026-07-21 20:14   ` Luis
2026-07-14 20:15 ` [PATCH v3 5/5] [PATCH 5/5] gdb/testsuite: Add FEAT_S1POE testcases srinath.parvathaneni
2026-07-21 20:38   ` Luis
2026-07-25  6:23   ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2748958-46b6-409f-8e67-4f843b1f6f37@gmail.com \
    --to=luis.machado.foss@gmail.com \
    --cc=Ezra.Sitorus@arm.com \
    --cc=Matthieu.Longo@arm.com \
    --cc=Srinath.Parvathaneni@arm.com \
    --cc=Yury.Khrustalev@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    --cc=simark@simark.ca \
    --cc=thiago.bauermann@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox