Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH/RFC] Refactor gdb.reverse/insn-reverse.c
Date: Wed, 25 Jan 2017 16:50:00 -0000	[thread overview]
Message-ID: <f0007a17-032a-bc9c-3caa-8ca94bd71a18@codesourcery.com> (raw)
In-Reply-To: <20170125161011.GW28060@E107787-LIN>

On 01/25/2017 10:10 AM, Yao Qi wrote:
> On 17-01-16 13:10:54, Luis Machado wrote:
>> I've broken up the main file into other files with arch-specific bits
>> (insn-support-<arch>.c). The main file will hold the generic pieces that will
>> take care of calling the tests.
>>
>
> It is reasonable to me.  Can we name arch-specific files as
> insn-reverse-<arch>.c?
>

Thanks for the review.

Would you reconsider this? I named it insn-support-<arch>.c because we 
already know this is a reverse debugging test (from gdb.reverse) and we 
are really testing instruction support. I'm fine either way though, and 
just wanted to add a little bit more context in the name.

Regards,
Luis


  reply	other threads:[~2017-01-25 16:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 19:11 Luis Machado
2017-01-24 16:20 ` Luis Machado
2017-01-25 16:10 ` Yao Qi
2017-01-25 16:50   ` Luis Machado [this message]
2017-01-25 17:44     ` Pedro Alves
2017-01-25 18:11       ` Luis Machado
2017-01-25 22:28         ` Yao Qi
2017-01-26 16:39           ` Luis Machado
2017-01-26 16:54             ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0007a17-032a-bc9c-3caa-8ca94bd71a18@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox