From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49287 invoked by alias); 25 Jan 2017 16:50:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49274 invoked by uid 89); 25 Jan 2017 16:50:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=insn-reverse, 170116, insnreverse, 17-01-16 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jan 2017 16:50:43 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cWQmP-000643-Ji from Luis_Gustavo@mentor.com ; Wed, 25 Jan 2017 08:50:41 -0800 Received: from [172.30.8.148] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 25 Jan 2017 08:50:38 -0800 Reply-To: Luis Machado Subject: Re: [PATCH/RFC] Refactor gdb.reverse/insn-reverse.c References: <1484593854-1791-1-git-send-email-lgustavo@codesourcery.com> <20170125161011.GW28060@E107787-LIN> To: Yao Qi CC: From: Luis Machado Message-ID: Date: Wed, 25 Jan 2017 16:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170125161011.GW28060@E107787-LIN> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00542.txt.bz2 On 01/25/2017 10:10 AM, Yao Qi wrote: > On 17-01-16 13:10:54, Luis Machado wrote: >> I've broken up the main file into other files with arch-specific bits >> (insn-support-.c). The main file will hold the generic pieces that will >> take care of calling the tests. >> > > It is reasonable to me. Can we name arch-specific files as > insn-reverse-.c? > Thanks for the review. Would you reconsider this? I named it insn-support-.c because we already know this is a reverse debugging test (from gdb.reverse) and we are really testing instruction support. I'm fine either way though, and just wanted to add a little bit more context in the name. Regards, Luis