From: Yao Qi <qiyaoltc@gmail.com>
To: Luis Machado <lgustavo@codesourcery.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH/RFC] Refactor gdb.reverse/insn-reverse.c
Date: Wed, 25 Jan 2017 22:28:00 -0000 [thread overview]
Message-ID: <20170125222841.553337r6jhwiybsr@localhost> (raw)
In-Reply-To: <9b4f74b9-b537-7513-2346-817d03075e76@codesourcery.com>
On 17-01-25 12:11:01, Luis Machado wrote:
> That is a reasonable assessment. insn-reverse.[c|exp] is redundant and IMO
> would benefit from renaming too.
>
> The support in "insn-support-<arch>.c means support for a set of
> instructions for this particular subsystem of gdb, therefore why i went with
> that name. Thinking about it further, instruction decoding support is the
> basis/foundation of reverse debugging, without which things would not work
> properly. But i may be overthinking. :-)
Every test is about testing some sort of support. Breakpoint test is
about breakpoint support, tracepoint test is about tracepoint support.
We don't have to explicitly mention "support" in the test case name,
IMO.
It is easy to relate "insn-reverse-<arch>.c" to "insn-reverse.c".
If you think "reverse" is redundant, "insn.c" and "insn-<arch>.c" is
acceptable to me too.
--
Yao
next prev parent reply other threads:[~2017-01-25 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 19:11 Luis Machado
2017-01-24 16:20 ` Luis Machado
2017-01-25 16:10 ` Yao Qi
2017-01-25 16:50 ` Luis Machado
2017-01-25 17:44 ` Pedro Alves
2017-01-25 18:11 ` Luis Machado
2017-01-25 22:28 ` Yao Qi [this message]
2017-01-26 16:39 ` Luis Machado
2017-01-26 16:54 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125222841.553337r6jhwiybsr@localhost \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox