From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105737 invoked by alias); 25 Jan 2017 22:28:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105709 invoked by uid 89); 25 Jan 2017 22:28:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:74.125.82.68, H*RU:74.125.82.68, Hx-languages-length:932, H*f:sk:9b4f74b X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jan 2017 22:28:46 +0000 Received: by mail-wm0-f68.google.com with SMTP id c85so45735403wmi.1 for ; Wed, 25 Jan 2017 14:28:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GcoDw1nMEHsq27dYG4/5T+HNx4HBRvRF/aRAFtGdXEo=; b=FgjqLM+RIXF2jySnVPPYyZYxL5Cq2SvwavJ8Z/Js7vEo9Faq1tNi8FZDVJpdorou+m jAp+4Pg1j70ZDeY0WSM09TFqU0gZz/STSCpQwzxtZkUU5tqStiRgv6Ex1hryVXQZvbtA 2U+sxwa4j7mwbtTk1z1+ycdNXOR7KC0STspBc3pEYwyCZyn1Pi0er/yAzrZ7bdFYfS/J kyzEBqXYHaU0RlCDVWvHZuMwp74cC75xo/nIH48RN0d+/cbY680ZWRD5KmcwzHImiJzU r0ToX6poZesmGOIrqKsTIZgnsn243czbZAYs2B2d5jxpfBA4FAMoQg1pTRjFl/EWbdvP pgFg== X-Gm-Message-State: AIkVDXIsC877elijR4WVlUivr05dzyOtcghUQ80SZ15OSHyoqE/JahVfsbHn12oE5KOnNA== X-Received: by 10.223.145.163 with SMTP id 32mr40946684wri.198.1485383324778; Wed, 25 Jan 2017 14:28:44 -0800 (PST) Received: from localhost ([2a02:c7d:8e80:c00:f496:8109:4db6:9490]) by smtp.gmail.com with ESMTPSA id l10sm24284043wrb.44.2017.01.25.14.28.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jan 2017 14:28:44 -0800 (PST) Date: Wed, 25 Jan 2017 22:28:00 -0000 From: Yao Qi To: Luis Machado Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH/RFC] Refactor gdb.reverse/insn-reverse.c Message-ID: <20170125222841.553337r6jhwiybsr@localhost> References: <1484593854-1791-1-git-send-email-lgustavo@codesourcery.com> <20170125161011.GW28060@E107787-LIN> <9b4f74b9-b537-7513-2346-817d03075e76@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b4f74b9-b537-7513-2346-817d03075e76@codesourcery.com> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00557.txt.bz2 On 17-01-25 12:11:01, Luis Machado wrote: > That is a reasonable assessment. insn-reverse.[c|exp] is redundant and IMO > would benefit from renaming too. > > The support in "insn-support-.c means support for a set of > instructions for this particular subsystem of gdb, therefore why i went with > that name. Thinking about it further, instruction decoding support is the > basis/foundation of reverse debugging, without which things would not work > properly. But i may be overthinking. :-) Every test is about testing some sort of support. Breakpoint test is about breakpoint support, tracepoint test is about tracepoint support. We don't have to explicitly mention "support" in the test case name, IMO. It is easy to relate "insn-reverse-.c" to "insn-reverse.c". If you think "reverse" is redundant, "insn.c" and "insn-.c" is acceptable to me too. -- Yao