From: Matthias Klose <doko@ubuntu.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Allow to link with ncursesw
Date: Wed, 20 Sep 2017 19:52:00 -0000 [thread overview]
Message-ID: <efd9c02d-767f-bc13-0c1e-85dbc8a7acd8@ubuntu.com> (raw)
In-Reply-To: <85b197cb-3a52-2e96-e7a3-a387afc3f158@redhat.com>
On 20.09.2017 20:39, Pedro Alves wrote:
> On 09/13/2017 11:29 AM, Matthias Klose wrote:
>> Triggered by https://launchpad.net/bugs/1275210, to be able to cope with UTF-8
>> characters in gdbtui. Ok for the trunk?
>
>>
>> Matthias
>>
>> * configure.ac: Search ncursesw before ncurses.
>> Check ncursesw/ncurses.h before ncurses/ncurses.h.
>> * gdb_curses.h: Include <ncursesw/ncurses.h>
>> * config.in, configure: Regenerate.
>>
>
> This sounds a bit scary if readline (or Python?) links with ncurses.
> Looking both upstream readline sources and our local copy in the tree,
> I don't see anything checking for ncursesw. Looking around for
> ncurses + ncursesw, I found:
>
> https://bugs.python.org/issue9408
> https://bugs.python.org/issue7384
>
> "Python3 now links _curses.so to ncurses library (bytes version) instead
> of ncursesw library (unicode version) if readline is linked to ncurses."
> ....
> "Thomas Dickey recommended not to load readline+ncurses and ncursesw
> at the same time."
>
> And:
>
> https://bugs.mageia.org/show_bug.cgi?id=2156
> bugs.debian.org/cgi-bin/bugreport.cgi?bug=602720
>
> I see you've been involved with all this before.
>
> Did you reach out to readline/bash, see if they're willing
> to try ncursesw before ncurses too? Don't we need at least
> a local patch to our local readline copy, to avoid breaking
> those that use it and have it link with ncurses?
afaik, this is only the case if readline is linked with one of the curses
libraries. However these days everybody seems to have readline linked to just
tinfo, so this shouldn't be an issue?
Python itself doesn't link to a curses library, it uses the only which is used
for readline.
Matthias
next prev parent reply other threads:[~2017-09-20 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 10:29 Matthias Klose
2017-09-20 18:39 ` Pedro Alves
2017-09-20 19:52 ` Matthias Klose [this message]
2017-09-20 21:22 ` Pedro Alves
2017-09-20 21:25 ` Pedro Alves
2017-09-20 23:58 ` John Baldwin
2017-09-22 10:22 ` Pedro Alves
2017-09-25 18:34 ` John Baldwin
2017-09-26 15:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd9c02d-767f-bc13-0c1e-85dbc8a7acd8@ubuntu.com \
--to=doko@ubuntu.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox