From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26223 invoked by alias); 20 Sep 2017 19:52:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25272 invoked by uid 89); 20 Sep 2017 19:52:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=everybody, Hx-languages-length:1730 X-HELO: einhorn-mail.in-berlin.de Received: from einhorn-mail.in-berlin.de (HELO einhorn-mail.in-berlin.de) (217.197.80.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 19:52:01 +0000 X-Envelope-From: doko@ubuntu.com Received: from [192.168.178.30] (ip5f5bd693.dynamic.kabel-deutschland.de [95.91.214.147]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-8+deb8u2) with ESMTP id v8KJprB3017981 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Sep 2017 21:51:54 +0200 Subject: Re: [patch] Allow to link with ncursesw To: Pedro Alves , gdb-patches@sourceware.org References: <85b197cb-3a52-2e96-e7a3-a387afc3f158@redhat.com> From: Matthias Klose Message-ID: Date: Wed, 20 Sep 2017 19:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <85b197cb-3a52-2e96-e7a3-a387afc3f158@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-09/txt/msg00516.txt.bz2 On 20.09.2017 20:39, Pedro Alves wrote: > On 09/13/2017 11:29 AM, Matthias Klose wrote: >> Triggered by https://launchpad.net/bugs/1275210, to be able to cope with UTF-8 >> characters in gdbtui. Ok for the trunk? > >> >> Matthias >> >> * configure.ac: Search ncursesw before ncurses. >> Check ncursesw/ncurses.h before ncurses/ncurses.h. >> * gdb_curses.h: Include >> * config.in, configure: Regenerate. >> > > This sounds a bit scary if readline (or Python?) links with ncurses. > Looking both upstream readline sources and our local copy in the tree, > I don't see anything checking for ncursesw. Looking around for > ncurses + ncursesw, I found: > > https://bugs.python.org/issue9408 > https://bugs.python.org/issue7384 > > "Python3 now links _curses.so to ncurses library (bytes version) instead > of ncursesw library (unicode version) if readline is linked to ncurses." > .... > "Thomas Dickey recommended not to load readline+ncurses and ncursesw > at the same time." > > And: > > https://bugs.mageia.org/show_bug.cgi?id=2156 > bugs.debian.org/cgi-bin/bugreport.cgi?bug=602720 > > I see you've been involved with all this before. > > Did you reach out to readline/bash, see if they're willing > to try ncursesw before ncurses too? Don't we need at least > a local patch to our local readline copy, to avoid breaking > those that use it and have it link with ncurses? afaik, this is only the case if readline is linked with one of the curses libraries. However these days everybody seems to have readline linked to just tinfo, so this shouldn't be an issue? Python itself doesn't link to a curses library, it uses the only which is used for readline. Matthias