Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: John Baldwin <jhb@freebsd.org>
Cc: Matthias Klose <doko@ubuntu.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Allow to link with ncursesw
Date: Tue, 26 Sep 2017 15:27:00 -0000	[thread overview]
Message-ID: <91be432b-c1bd-bd3f-cda1-246e0d4fc9f3@redhat.com> (raw)
In-Reply-To: <6369122.laJjuqZJ79@ralph.baldwin.cx>

On 09/25/2017 06:36 PM, John Baldwin wrote:
> On Friday, September 22, 2017 11:21:58 AM Pedro Alves wrote:
>>
>> On 09/21/2017 12:56 AM, John Baldwin wrote:

>> Thanks!  If you could also confirm with the in-tree readline
>> as well (i.e., without --with-system-readline), that'd be great.  The
>> original Python reports I linked at were about readline compiled against
>> ncurses and then something else linked against ncursesw, IIUC.  I don't
>> know whether that might make a difference, but I guess it could, if
>> readline is compiled against some curses structure that ends up
>> mismatching with the called curses functions due to odd interposition
>> effects.
>>
>> If that causes a problem, then we may need to patch our local
>> readline copy matching gdb.
>>
>> Otherwise, if all is fine, then I think we've given this
>> due diligence and Matthias' patch is fine with me.
> 
> This seems to work fine in my testing both in the port (which with this
> change now only links against libncursesw instead of both) and in my own
> builds (which do not use --with-system-readline).

Thanks much!  I've merged the patch to master, then.

Thanks,
Pedro Alves


      reply	other threads:[~2017-09-26 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 10:29 Matthias Klose
2017-09-20 18:39 ` Pedro Alves
2017-09-20 19:52   ` Matthias Klose
2017-09-20 21:22     ` Pedro Alves
2017-09-20 21:25       ` Pedro Alves
2017-09-20 23:58       ` John Baldwin
2017-09-22 10:22         ` Pedro Alves
2017-09-25 18:34           ` John Baldwin
2017-09-26 15:27             ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91be432b-c1bd-bd3f-cda1-246e0d4fc9f3@redhat.com \
    --to=palves@redhat.com \
    --cc=doko@ubuntu.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox