From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48332 invoked by alias); 26 Sep 2017 15:27:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48316 invoked by uid 89); 26 Sep 2017 15:27:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=much, much!, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 15:26:59 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 85AB63DBD1; Tue, 26 Sep 2017 15:26:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85AB63DBD1 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB2D171C80; Tue, 26 Sep 2017 15:26:57 +0000 (UTC) Subject: Re: [patch] Allow to link with ncursesw To: John Baldwin References: <3057121.ifSOzBUOOt@ralph.baldwin.cx> <3e48c0e2-d870-c421-7c5a-49c00ca2bbf1@redhat.com> <6369122.laJjuqZJ79@ralph.baldwin.cx> Cc: Matthias Klose , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <91be432b-c1bd-bd3f-cda1-246e0d4fc9f3@redhat.com> Date: Tue, 26 Sep 2017 15:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <6369122.laJjuqZJ79@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00805.txt.bz2 On 09/25/2017 06:36 PM, John Baldwin wrote: > On Friday, September 22, 2017 11:21:58 AM Pedro Alves wrote: >> >> On 09/21/2017 12:56 AM, John Baldwin wrote: >> Thanks! If you could also confirm with the in-tree readline >> as well (i.e., without --with-system-readline), that'd be great. The >> original Python reports I linked at were about readline compiled against >> ncurses and then something else linked against ncursesw, IIUC. I don't >> know whether that might make a difference, but I guess it could, if >> readline is compiled against some curses structure that ends up >> mismatching with the called curses functions due to odd interposition >> effects. >> >> If that causes a problem, then we may need to patch our local >> readline copy matching gdb. >> >> Otherwise, if all is fine, then I think we've given this >> due diligence and Matthias' patch is fine with me. > > This seems to work fine in my testing both in the port (which with this > change now only links against libncursesw instead of both) and in my own > builds (which do not use --with-system-readline). Thanks much! I've merged the patch to master, then. Thanks, Pedro Alves