From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] gdb: move read{now, never}_symbol_files declarations to symfile.h
Date: Tue, 12 Jan 2021 10:42:25 -0500 [thread overview]
Message-ID: <ed3d5a63-ce3b-ca40-c307-1837ea36a468@polymtl.ca> (raw)
In-Reply-To: <CAPTJ0XG0k7o0ZYNzR3Q1tZqc6c8eGpysmqGvmdfZFr4MRh9N_w@mail.gmail.com>
On 2021-01-12 9:58 a.m., Christian Biesinger wrote:
> On Tue, Jan 12, 2021 at 6:44 AM Simon Marchi via Gdb-patches
> <gdb-patches@sourceware.org> wrote:
>> -int readnow_symbol_files; /* Read full symbols immediately. */
>> -int readnever_symbol_files; /* Never read full symbols. */
>
> Looks like these comments didn't make it into the header file?
>
> (It also seems like these should be bool, though I understand that's a
> bigger change)
>
> Christian
>
Oh, I must have failed to add/commit them. Fixed locally, thanks!
Simon
next prev parent reply other threads:[~2021-01-12 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 5:44 [PATCH 1/2] gdb: move baud_rate and serial_parity declarations to serial.h Simon Marchi via Gdb-patches
2021-01-12 5:44 ` [PATCH 2/2] gdb: move read{now, never}_symbol_files declarations to symfile.h Simon Marchi via Gdb-patches
2021-01-12 14:58 ` Christian Biesinger via Gdb-patches
2021-01-12 15:42 ` Simon Marchi via Gdb-patches [this message]
2021-01-12 18:28 ` Tom Tromey
2021-01-12 19:20 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3d5a63-ce3b-ca40-c307-1837ea36a468@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox