From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id E0G0AmvD/V/bRgAAWB0awg (envelope-from ) for ; Tue, 12 Jan 2021 10:42:35 -0500 Received: by simark.ca (Postfix, from userid 112) id EE0821EF7E; Tue, 12 Jan 2021 10:42:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9DFFB1E940 for ; Tue, 12 Jan 2021 10:42:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13A883892451; Tue, 12 Jan 2021 15:42:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13A883892451 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610466154; bh=YZzaEDKuQRE3DpRVbHKzxmb0Mhq80es9o+HR4hXZYJo=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ajK2A8IUF/5gIWkh6gfUSkx+domOzyiTIEUP+i+qQdGo2waDcRmM6JSs/xAyoZJ9y W8C1qgWCnxadZT+KvGgFrbJyC5Kjr4EHtbq3iz3QZF81R/t8TlfTgspdKA3wwLAUTh Oo9Ep0+Dkkq5RIbnn3QnKXrWFjobBzr0vvl31MtQ= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id F2A863857C6B for ; Tue, 12 Jan 2021 15:42:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F2A863857C6B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10CFgPUF030642 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Jan 2021 10:42:30 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10CFgPUF030642 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6EDC91E940; Tue, 12 Jan 2021 10:42:25 -0500 (EST) Subject: Re: [PATCH 2/2] gdb: move read{now, never}_symbol_files declarations to symfile.h To: Christian Biesinger References: <20210112054441.1188693-1-simon.marchi@polymtl.ca> <20210112054441.1188693-2-simon.marchi@polymtl.ca> Message-ID: Date: Tue, 12 Jan 2021 10:42:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 12 Jan 2021 15:42:25 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-12 9:58 a.m., Christian Biesinger wrote: > On Tue, Jan 12, 2021 at 6:44 AM Simon Marchi via Gdb-patches > wrote: >> -int readnow_symbol_files; /* Read full symbols immediately. */ >> -int readnever_symbol_files; /* Never read full symbols. */ > > Looks like these comments didn't make it into the header file? > > (It also seems like these should be bool, though I understand that's a > bigger change) > > Christian > Oh, I must have failed to add/commit them. Fixed locally, thanks! Simon