Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/2] gdb: move read{now, never}_symbol_files declarations to symfile.h
Date: Tue, 12 Jan 2021 00:44:41 -0500	[thread overview]
Message-ID: <20210112054441.1188693-2-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20210112054441.1188693-1-simon.marchi@polymtl.ca>

... since they are defined in symfile.c.

gdb/ChangeLog:

	* top.h (readnow_symbol_files, readnever_symbol_files): Move
	declarations to ...
	* symfile.h: ... here.
	* symfile.c: Update doc.

Change-Id: Ie35a80d236bea70947bc496f66f62c8c621670b4
---
 gdb/symfile.c | 10 ++++++++--
 gdb/symfile.h |  4 ++++
 gdb/top.h     |  4 ----
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/gdb/symfile.c b/gdb/symfile.c
index 82693f913672..ec5d34ac7833 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -85,8 +85,14 @@ using clear_symtab_users_cleanup
   = FORWARD_SCOPE_EXIT (clear_symtab_users);
 
 /* Global variables owned by this file.  */
-int readnow_symbol_files;	/* Read full symbols immediately.  */
-int readnever_symbol_files;	/* Never read full symbols.  */
+
+/* See symfile.h.  */
+
+int readnow_symbol_files;
+
+/* See symfile.h.  */
+
+int readnever_symbol_files;
 
 /* Functions this file defines.  */
 
diff --git a/gdb/symfile.h b/gdb/symfile.h
index a6f8fafc8952..f1ce75457d67 100644
--- a/gdb/symfile.h
+++ b/gdb/symfile.h
@@ -641,4 +641,8 @@ extern gdb_bfd_ref_ptr find_separate_debug_file_in_section (struct objfile *);
 
 extern bool separate_debug_file_debug;
 
+extern int readnow_symbol_files;
+extern int readnever_symbol_files;
+
+
 #endif /* !defined(SYMFILE_H) */
diff --git a/gdb/top.h b/gdb/top.h
index a08f448778ac..a31b19ae9542 100644
--- a/gdb/top.h
+++ b/gdb/top.h
@@ -273,10 +273,6 @@ extern void set_prompt (const char *s);
 
 extern int gdb_in_secondary_prompt_p (struct ui *ui);
 
-/* From random places.  */
-extern int readnow_symbol_files;
-extern int readnever_symbol_files;
-
 /* Perform _initialize initialization.  */
 extern void gdb_init (char *);
 
-- 
2.29.2


  reply	other threads:[~2021-01-12  5:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  5:44 [PATCH 1/2] gdb: move baud_rate and serial_parity declarations to serial.h Simon Marchi via Gdb-patches
2021-01-12  5:44 ` Simon Marchi via Gdb-patches [this message]
2021-01-12 14:58   ` [PATCH 2/2] gdb: move read{now, never}_symbol_files declarations to symfile.h Christian Biesinger via Gdb-patches
2021-01-12 15:42     ` Simon Marchi via Gdb-patches
2021-01-12 18:28       ` Tom Tromey
2021-01-12 19:20         ` Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210112054441.1188693-2-simon.marchi@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox