From: Pedro Alves <palves@redhat.com>
To: Ivo Raisr <ivo.raisr@oracle.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR tdep/20928] Decode properly flags of %ccr register on sparc64
Date: Fri, 17 Mar 2017 16:42:00 -0000 [thread overview]
Message-ID: <ecf910f3-f120-e59b-8b66-e4ffd2522ac1@redhat.com> (raw)
In-Reply-To: <118a1bb4-80c3-3458-26ae-de3248a82dea@oracle.com>
On 03/14/2017 08:37 AM, Ivo Raisr wrote:
> Ping II.
> Can I get +1 for this small patch?
> I.
I was hoping that someone who actually knows sparc would
take a look. :-)
My only comment would be wondering about a adding some test.
E.g., some small assembly test in gdb.arch/ that you'd single-step
and make sure that the expected changes can be observed in
the affected registers / flags.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-03-17 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <37ce765b-9064-a766-c843-a25b69030528@oracle.com>
2017-03-07 13:06 ` Ivo Raisr
2017-03-09 22:19 ` Ivo Raisr
2017-03-14 8:37 ` Ivo Raisr
2017-03-17 16:42 ` Pedro Alves [this message]
2017-03-20 15:55 ` Ivo Raisr
2017-03-20 16:48 ` Pedro Alves
2017-03-21 3:51 ` Ivo Raisr
2017-03-21 11:47 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecf910f3-f120-e59b-8b66-e4ffd2522ac1@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ivo.raisr@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox