From: jose.marchesi@oracle.com (Jose E. Marchesi)
To: Ivo Raisr <ivo.raisr@oracle.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR tdep/20928] Decode properly flags of %ccr register on sparc64
Date: Tue, 21 Mar 2017 11:47:00 -0000 [thread overview]
Message-ID: <87y3vysvfs.fsf@oracle.com> (raw)
In-Reply-To: <a545f725-f69a-cd52-bbb0-039d04cc90ee@oracle.com> (Ivo Raisr's message of "Tue, 21 Mar 2017 04:50:28 +0100")
> Very nice! Feel free to push with a couple nits below fixed.
>
>> diff --git a/gdb/testsuite/gdb.arch/sparc64-regs.exp b/gdb/testsuite/gdb.arch/sparc64-regs.exp
>> new file mode 100644
>> index 0000000..fff9964
>> --- /dev/null
>> +++ b/gdb/testsuite/gdb.arch/sparc64-regs.exp
>> @@ -0,0 +1,117 @@
>> +# Copyright 2017-2017 Free Software Foundation, Inc.
>
> Single "2017".
>
>> +##########################################
>> +set lno [gdb_get_line_number "sparc64-regs.exp: after first %fsr" $srcfile]
>> +gdb_test "break $srcfile:$lno" "Breakpoint \[0-9\] at .*"
>
> Give this gdb_test a 3rd parameter that avoids showing the line
> number in gdb.sum, to avoid spurious/unnecessary gdb.sum change
> if/when the test source changes.
Thank you for your comments.
Attached is the changed patch and ChangeLog entries.
I will ask Jose to push the changes on my behalf as I don't have write
access to the binutils-gdb repository.
Pushed.
Salud!
prev parent reply other threads:[~2017-03-21 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <37ce765b-9064-a766-c843-a25b69030528@oracle.com>
2017-03-07 13:06 ` Ivo Raisr
2017-03-09 22:19 ` Ivo Raisr
2017-03-14 8:37 ` Ivo Raisr
2017-03-17 16:42 ` Pedro Alves
2017-03-20 15:55 ` Ivo Raisr
2017-03-20 16:48 ` Pedro Alves
2017-03-21 3:51 ` Ivo Raisr
2017-03-21 11:47 ` Jose E. Marchesi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3vysvfs.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=ivo.raisr@oracle.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox