From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-137721-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22229 invoked by alias); 21 Mar 2017 11:47:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 22153 invoked by uid 89); 21 Mar 2017 11:47:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=salud, Salud
X-HELO: aserp1040.oracle.com
Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Mar 2017 11:47:43 +0000
Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])	by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v2LBleje006640	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Tue, 21 Mar 2017 11:47:41 GMT
Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])	by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v2LBle52021653	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Tue, 21 Mar 2017 11:47:40 GMT
Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22])	by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v2LBle1u025823;	Tue, 21 Mar 2017 11:47:40 GMT
Received: from termi.oracle.com (/10.175.193.238)	by default (Oracle Beehive Gateway v4.0)	with ESMTP ; Tue, 21 Mar 2017 04:47:39 -0700
From: jose.marchesi@oracle.com (Jose E. Marchesi)
To: Ivo Raisr <ivo.raisr@oracle.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR tdep/20928] Decode properly flags of %ccr register on sparc64
References: <37ce765b-9064-a766-c843-a25b69030528@oracle.com>	<705eae25-cf4e-fc81-dd8e-1e622b340486@oracle.com>	<bb05a51e-775a-a33f-84e0-89b918fec6c6@oracle.com>	<118a1bb4-80c3-3458-26ae-de3248a82dea@oracle.com>	<ecf910f3-f120-e59b-8b66-e4ffd2522ac1@redhat.com>	<cc693e5a-5d0d-be77-2048-069e304dd331@oracle.com>	<c4103ecd-0991-23ca-79cd-0bf2d09b0768@redhat.com>	<a545f725-f69a-cd52-bbb0-039d04cc90ee@oracle.com>
Date: Tue, 21 Mar 2017 11:47:00 -0000
In-Reply-To: <a545f725-f69a-cd52-bbb0-039d04cc90ee@oracle.com> (Ivo Raisr's	message of "Tue, 21 Mar 2017 04:50:28 +0100")
Message-ID: <87y3vysvfs.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2017-03/txt/msg00365.txt.bz2


    > Very nice!  Feel free to push with a couple nits below fixed.
    >
    >> diff --git a/gdb/testsuite/gdb.arch/sparc64-regs.exp b/gdb/testsuite/gdb.arch/sparc64-regs.exp
    >> new file mode 100644
    >> index 0000000..fff9964
    >> --- /dev/null
    >> +++ b/gdb/testsuite/gdb.arch/sparc64-regs.exp
    >> @@ -0,0 +1,117 @@
    >> +# Copyright 2017-2017 Free Software Foundation, Inc.
    >
    > Single "2017".
    >
    >> +##########################################
    >> +set lno [gdb_get_line_number "sparc64-regs.exp: after first %fsr" $srcfile]
    >> +gdb_test "break $srcfile:$lno" "Breakpoint \[0-9\] at .*"
    >
    > Give this gdb_test a 3rd parameter that avoids showing the line
    > number in gdb.sum, to avoid spurious/unnecessary gdb.sum change
    > if/when the test source changes.
    
    Thank you for your comments.
    Attached is the changed patch and ChangeLog entries.
    I will ask Jose to push the changes on my behalf as I don't have write
    access to the binutils-gdb repository.
    
Pushed.
Salud!