From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71504 invoked by alias); 17 Mar 2017 16:42:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69610 invoked by uid 89); 17 Mar 2017 16:42:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:489 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Mar 2017 16:42:06 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 805EB7AE95; Fri, 17 Mar 2017 16:42:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 805EB7AE95 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 805EB7AE95 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF5D66046B; Fri, 17 Mar 2017 16:42:06 +0000 (UTC) Subject: Re: [PATCH] [PR tdep/20928] Decode properly flags of %ccr register on sparc64 To: Ivo Raisr , gdb-patches@sourceware.org References: <37ce765b-9064-a766-c843-a25b69030528@oracle.com> <705eae25-cf4e-fc81-dd8e-1e622b340486@oracle.com> <118a1bb4-80c3-3458-26ae-de3248a82dea@oracle.com> From: Pedro Alves Message-ID: Date: Fri, 17 Mar 2017 16:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <118a1bb4-80c3-3458-26ae-de3248a82dea@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00320.txt.bz2 On 03/14/2017 08:37 AM, Ivo Raisr wrote: > Ping II. > Can I get +1 for this small patch? > I. I was hoping that someone who actually knows sparc would take a look. :-) My only comment would be wondering about a adding some test. E.g., some small assembly test in gdb.arch/ that you'd single-step and make sure that the expected changes can be observed in the affected registers / flags. Thanks, Pedro Alves