Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>,
	Yao Qi <qiyaoltc@gmail.com>,
	       gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Add unit test to aarch64 prologue analyzer
Date: Thu, 01 Dec 2016 12:53:00 -0000	[thread overview]
Message-ID: <eb2dd40c-ccc2-569b-374e-f3bf8ff3a460@redhat.com> (raw)
In-Reply-To: <55ea5ba0-6ea7-686d-1841-48875ed8587c@codesourcery.com>

On 11/30/2016 07:30 PM, Luis Machado wrote:

> Should the curly braces both be on their own lines as the rest of the
> uses? I see mixed formatting in the uses of namespace we currently have.
> We should pick one and go with it.
> 
> I particularly dislike the curly brace on the same line being used to
> GNU's coding standards.

Looking at the GCC codebase, the style with trailing { on the same
line (my preferred) is prevalent:

 $ grep "^namespace " gcc/* | grep "{$" | wc -l
 282
 $ grep "^namespace " gcc/* | grep -v "{$" | wc -l
 28

That style lends itself to opening nested namespaces more
like a FQN, like:

 namespace foo { namespace bar {

With C++17, we'll be able to write:

 namespace foo::bar {

Thanks,
Pedro Alves


  reply	other threads:[~2016-12-01 12:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 14:12 Yao Qi
2016-11-29 14:12 ` [PATCH 2/2] [AArch64] Recognize STR instruction in prologue Yao Qi
2016-11-30 18:33   ` Pedro Alves
2016-11-29 14:58 ` [PATCH 1/2] Add unit test to aarch64 prologue analyzer Antoine Tremblay
2016-11-30 11:15   ` Yao Qi
2016-11-30 11:53     ` Antoine Tremblay
2016-11-30 16:35       ` Yao Qi
2016-11-30 16:42         ` Antoine Tremblay
2016-11-30 18:16         ` Pedro Alves
2016-11-30 18:29 ` Pedro Alves
2016-11-30 18:38   ` Pedro Alves
2016-11-30 19:30 ` Luis Machado
2016-12-01 12:53   ` Pedro Alves [this message]
2016-12-01 11:17 ` [PATCH 1/2 v2] " Yao Qi
2016-12-01 11:17   ` [PATCH 2/2 v2] [AArch64] Recognize STR instruction in prologue Yao Qi
2016-12-01 13:07     ` Pedro Alves
2016-12-02  9:42       ` Yao Qi
2016-12-01 12:57   ` [PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer Pedro Alves
2016-12-01 15:21     ` Yao Qi
2016-12-01 16:04       ` Yao Qi
2016-12-01 18:05         ` Pedro Alves
2016-12-02  9:40           ` Yao Qi
2016-12-02 11:11             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb2dd40c-ccc2-569b-374e-f3bf8ff3a460@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox