From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43045 invoked by alias); 1 Dec 2016 12:53:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43005 invoked by uid 89); 1 Dec 2016 12:53:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=lends X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Dec 2016 12:53:32 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55A9EC05AA64; Thu, 1 Dec 2016 12:53:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB1CrSEd030970; Thu, 1 Dec 2016 07:53:30 -0500 Subject: Re: [PATCH 1/2] Add unit test to aarch64 prologue analyzer To: Luis Machado , Yao Qi , gdb-patches@sourceware.org References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> <55ea5ba0-6ea7-686d-1841-48875ed8587c@codesourcery.com> From: Pedro Alves Message-ID: Date: Thu, 01 Dec 2016 12:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <55ea5ba0-6ea7-686d-1841-48875ed8587c@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00025.txt.bz2 On 11/30/2016 07:30 PM, Luis Machado wrote: > Should the curly braces both be on their own lines as the rest of the > uses? I see mixed formatting in the uses of namespace we currently have. > We should pick one and go with it. > > I particularly dislike the curly brace on the same line being used to > GNU's coding standards. Looking at the GCC codebase, the style with trailing { on the same line (my preferred) is prevalent: $ grep "^namespace " gcc/* | grep "{$" | wc -l 282 $ grep "^namespace " gcc/* | grep -v "{$" | wc -l 28 That style lends itself to opening nested namespaces more like a FQN, like: namespace foo { namespace bar { With C++17, we'll be able to write: namespace foo::bar { Thanks, Pedro Alves