From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer
Date: Thu, 01 Dec 2016 12:57:00 -0000 [thread overview]
Message-ID: <c16d6a3a-4e11-d018-8f82-fdde33c34a44@redhat.com> (raw)
In-Reply-To: <1480591000-19457-1-git-send-email-yao.qi@linaro.org>
On 12/01/2016 11:16 AM, Yao Qi wrote:
> +#if GDB_SELF_TEST
> +
> +namespace selftests
> +{
> +
> + /* Instruction reader from manually cooked instruction sequences. */
> +
> + class instruction_reader_test : public abstract_instruction_reader
> + {
This whole class should be indented at column 0.
> + public:
> + template<size_t SIZE>
> + instruction_reader_test (const uint32_t (&insns)[SIZE])
> + : m_insns (insns), m_insns_size (SIZE)
> + {}
Please add "explicit". Sorry that I missed adding it myself.
Otherwise LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-12-01 12:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 14:12 [PATCH 1/2] " Yao Qi
2016-11-29 14:12 ` [PATCH 2/2] [AArch64] Recognize STR instruction in prologue Yao Qi
2016-11-30 18:33 ` Pedro Alves
2016-11-29 14:58 ` [PATCH 1/2] Add unit test to aarch64 prologue analyzer Antoine Tremblay
2016-11-30 11:15 ` Yao Qi
2016-11-30 11:53 ` Antoine Tremblay
2016-11-30 16:35 ` Yao Qi
2016-11-30 16:42 ` Antoine Tremblay
2016-11-30 18:16 ` Pedro Alves
2016-11-30 18:29 ` Pedro Alves
2016-11-30 18:38 ` Pedro Alves
2016-11-30 19:30 ` Luis Machado
2016-12-01 12:53 ` Pedro Alves
2016-12-01 11:17 ` [PATCH 1/2 v2] " Yao Qi
2016-12-01 11:17 ` [PATCH 2/2 v2] [AArch64] Recognize STR instruction in prologue Yao Qi
2016-12-01 13:07 ` Pedro Alves
2016-12-02 9:42 ` Yao Qi
2016-12-01 12:57 ` Pedro Alves [this message]
2016-12-01 15:21 ` [PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer Yao Qi
2016-12-01 16:04 ` Yao Qi
2016-12-01 18:05 ` Pedro Alves
2016-12-02 9:40 ` Yao Qi
2016-12-02 11:11 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c16d6a3a-4e11-d018-8f82-fdde33c34a44@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox