From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135524-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 49895 invoked by alias); 1 Dec 2016 12:57:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 49861 invoked by uid 89); 1 Dec 2016 12:57:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:612
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Dec 2016 12:57:47 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id AA07A624BC;	Thu,  1 Dec 2016 12:57:46 +0000 (UTC)
Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB1CvjLe016391;	Thu, 1 Dec 2016 07:57:46 -0500
Subject: Re: [PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> <1480591000-19457-1-git-send-email-yao.qi@linaro.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <c16d6a3a-4e11-d018-8f82-fdde33c34a44@redhat.com>
Date: Thu, 01 Dec 2016 12:57:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1480591000-19457-1-git-send-email-yao.qi@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-12/txt/msg00026.txt.bz2

On 12/01/2016 11:16 AM, Yao Qi wrote:

> +#if GDB_SELF_TEST
> +
> +namespace selftests
> +{
> +
> +  /* Instruction reader from manually cooked instruction sequences.  */
> +
> +  class instruction_reader_test : public abstract_instruction_reader
> +  {

This whole class should be indented at column 0.

> +  public:
> +    template<size_t SIZE>
> +    instruction_reader_test (const uint32_t (&insns)[SIZE])
> +      : m_insns (insns), m_insns_size (SIZE)
> +    {}

Please add "explicit".  Sorry that I missed adding it myself.

Otherwise LGTM.

Thanks,
Pedro Alves