From: Tom de Vries <tdevries@suse.de>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp
Date: Fri, 29 Mar 2024 11:48:11 +0100 [thread overview]
Message-ID: <ea984c6d-e0cb-4e0f-891a-90ab3b9ea4e4@suse.de> (raw)
In-Reply-To: <3b02c34b-3604-48dd-93e9-c90d749c28f0@FreeBSD.org>
On 3/28/24 18:26, John Baldwin wrote:
> On 3/27/24 12:23 PM, Tom de Vries wrote:
>> On fedora rawhide, with test-case gdb.base/rtld-step.exp I get:
>> ...
>> static-pie-static-libc.c: In function '_start':^M
>> static-pie-static-libc.c:1:22: error: \
>> implicit declaration of function '_exit'
>> [-Wimplicit-function-declaration]^M
>> 1 | void _start (void) { _exit (0); }^M
>> | ^~~~~^M
>> compiler exited with status 1
>> ...
>> UNTESTED: gdb.base/rtld-step.exp: failed to compile \
>> (-static-pie not supported or static libc missing)
>> ...
>>
>> Fix this by adding the missing include.
>>
>> Tested on aarch64-linux.
>
> Approved-By: John Baldwin <jhb@FreeBSD.org>
>
Hi John,
thanks for the review.
I had already committed after the approval of Kevin, so unfortunately
this was committed without your approved-by tag.
Thanks,
- Tom
prev parent reply other threads:[~2024-03-29 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:23 Tom de Vries
2024-03-28 2:24 ` Kevin Buettner
2024-03-28 17:26 ` John Baldwin
2024-03-29 10:48 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea984c6d-e0cb-4e0f-891a-90ab3b9ea4e4@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox