Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp
Date: Wed, 27 Mar 2024 19:24:24 -0700	[thread overview]
Message-ID: <20240327192424.585b7896@f39-zbm-amd> (raw)
In-Reply-To: <20240327162329.2242-1-tdevries@suse.de>

Hi Tom,

On Wed, 27 Mar 2024 17:23:29 +0100
Tom de Vries <tdevries@suse.de> wrote:

> On fedora rawhide, with test-case gdb.base/rtld-step.exp I get:
> ...
> static-pie-static-libc.c: In function '_start':^M
> static-pie-static-libc.c:1:22: error: \
>   implicit declaration of function '_exit' [-Wimplicit-function-declaration]^M
>     1 | void _start (void) { _exit (0); }^M
>       |                      ^~~~~^M
> compiler exited with status 1
>   ...
> UNTESTED: gdb.base/rtld-step.exp: failed to compile \
>   (-static-pie not supported or static libc missing)
> ...
> 
> Fix this by adding the missing include.
> 
> Tested on aarch64-linux.

Thanks for fixing this.

Approved-by: Kevin Buettner <kevinb@redhat.com>


  reply	other threads:[~2024-03-28  2:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 16:23 Tom de Vries
2024-03-28  2:24 ` Kevin Buettner [this message]
2024-03-28 17:26 ` John Baldwin
2024-03-29 10:48   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240327192424.585b7896@f39-zbm-amd \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox