From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UwobIffUBGaX7RgAWB0awg (envelope-from ) for ; Wed, 27 Mar 2024 22:24:55 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VmPUFhOf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 753FC1E0C0; Wed, 27 Mar 2024 22:24:55 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 560901E08C for ; Wed, 27 Mar 2024 22:24:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95D8A385E453 for ; Thu, 28 Mar 2024 02:24:52 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C89B63858D20 for ; Thu, 28 Mar 2024 02:24:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C89B63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C89B63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711592672; cv=none; b=iAv8Jc2AZBAnlLI0czOA3YBmADPnzjFYdJGRW0E3lvP1+zte9NJ34LndXA7W834Xj2M5limYLq1Lck6w8XWtkx8/eeGUmmzFm5rrTqBH5lvuRCj46cJsj71Bl61ObzMJN9XirWGv2dh+A/bWGJpxm2ZIS/yLRg5Kh5p+JYNr4oA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711592672; c=relaxed/simple; bh=Mnd82SKW/bRNH+ZUJ1FHCc7SbGdP2MDwqts+x46LnfY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Xh0F7DuxV5E43ZtGDOKpAiIQ24fTsD/UiX1mrjM0PqHq1/KlxGFgR4O2z9UgVyj09yS4k32W1RNnWhY6e2KOfajHx3+0ieYvxKHAo2qoYP68qf+8vAs/sBVjx3ZVZZYpqDCln2kewDFK7DemGoEzJ7QEacRZ9MAGZfFtxe+VDe4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711592668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gcFKJgVYrEEQtas+2xKKz9O7R+URDzOtbKass4QAT88=; b=VmPUFhOfipbW+UaaQO9CLejSvyXBv7Z/dVi9E0rWorTQu3bfDRfVoINeTWZ9vI1a3M77zO KSyGZiMGIUSLm0Zz0J3BmUXnWp8Gw+9Nt9p6AUgFVGi1F8yIK6NCSicjg+x/DemwMMNkj6 tNMVcMGEbssA2TEHFH6yPdXevgfuQs4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-251-2ugRcn7kNpiz7TiuErb_KQ-1; Wed, 27 Mar 2024 22:24:26 -0400 X-MC-Unique: 2ugRcn7kNpiz7TiuErb_KQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8FF913C367E4; Thu, 28 Mar 2024 02:24:26 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.10.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A11D492BC8; Thu, 28 Mar 2024 02:24:26 +0000 (UTC) Date: Wed, 27 Mar 2024 19:24:24 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp Message-ID: <20240327192424.585b7896@f39-zbm-amd> In-Reply-To: <20240327162329.2242-1-tdevries@suse.de> References: <20240327162329.2242-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi Tom, On Wed, 27 Mar 2024 17:23:29 +0100 Tom de Vries wrote: > On fedora rawhide, with test-case gdb.base/rtld-step.exp I get: > ... > static-pie-static-libc.c: In function '_start':^M > static-pie-static-libc.c:1:22: error: \ > implicit declaration of function '_exit' [-Wimplicit-function-declaration]^M > 1 | void _start (void) { _exit (0); }^M > | ^~~~~^M > compiler exited with status 1 > ... > UNTESTED: gdb.base/rtld-step.exp: failed to compile \ > (-static-pie not supported or static libc missing) > ... > > Fix this by adding the missing include. > > Tested on aarch64-linux. Thanks for fixing this. Approved-by: Kevin Buettner