From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TH72GYWcBmam2BoAWB0awg (envelope-from ) for ; Fri, 29 Mar 2024 06:48:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=lcHmFtCC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ddhSVcwB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5D4B61E0C0; Fri, 29 Mar 2024 06:48:37 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2AA551E030 for ; Fri, 29 Mar 2024 06:48:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 61B213858D37 for ; Fri, 29 Mar 2024 10:48:34 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 93F3F3858D20 for ; Fri, 29 Mar 2024 10:48:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93F3F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93F3F3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711709295; cv=none; b=bPd09e/DSdz/IN7Qp5+xRccybAOAqwGKJ3upItJtgHJpAOHNzwH/50jiQfRTp2UKHpF4r0k9qsjzxQS/KigN5Gm+48gz1jcIeKn8O8EsaLCcs+A3e06hugQZqEvHBm+DUQkxBYfdEiI4BRFL7VBg+Xcz1VC+Awxku2GErPguxSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711709295; c=relaxed/simple; bh=gSuivBL+qi4VAqyAH+vE2lf1zbecZovz9i/sSO+0f1o=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=FsTkJsTYpE2Jn4Sq2azREykTGTUgm7IgT+plSXZqQTn4/981CvfkJKwzirjFDyzoFRsQP3yS8Ra7L55cwGnFSechwKvVRaoQq0IpdlLuCGbqWUI+Pp1Fbp3vabZLMLmHtJ2TVqjMW6XlA1Pw0bh02yWML3vI8I0nkStJPdMJ/5E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DFFD734CCC; Fri, 29 Mar 2024 10:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711709290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9+3ZbzoQnWhAuuCBMuWT25RQkXnNX5RX0wtCqhnYChc=; b=lcHmFtCCs01G/aZ3zgLjkMwfsKvbcCIm+X4B8xcnBel4jcD4SBj3/SuEt7Sishr4wke+Bz sL+WsFR8ZaX4zHS2FZhOpocz7a8OQ1Ae/ECFSJfnwyrqptgFdh0UffITCX56PqhRXM9KoK 1yPVMFCryVwnVxp1Pxy/5dMNoQ2WBKY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711709290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9+3ZbzoQnWhAuuCBMuWT25RQkXnNX5RX0wtCqhnYChc=; b=ddhSVcwB8PVUBeuhTvxHUQ0l30zT3BOPHLDSb+uwVm64YPirs4J9E8OrAiSoB/J7Y+JTVw RGKn+DXQkqzs8sDA== Authentication-Results: smtp-out1.suse.de; dkim=none Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id B67ED13A89; Fri, 29 Mar 2024 10:48:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id heq9KmqcBmaQJwAAn2gu4w (envelope-from ); Fri, 29 Mar 2024 10:48:10 +0000 Message-ID: Date: Fri, 29 Mar 2024 11:48:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org References: <20240327162329.2242-1-tdevries@suse.de> <3b02c34b-3604-48dd-93e9-c90d749c28f0@FreeBSD.org> From: Tom de Vries In-Reply-To: <3b02c34b-3604-48dd-93e9-c90d749c28f0@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-0.38 / 50.00]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.08)[63.55%]; MX_GOOD(-0.01)[]; XM_UA_NO_VERSION(0.01)[]; MID_RHS_MATCH_FROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:98:from,2a07:de40:b281:106:10:150:64:167:received]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[] X-Spam-Level: X-Spam-Score: -0.38 X-Spamd-Bar: / X-Rspamd-Queue-Id: DFFD734CCC X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/28/24 18:26, John Baldwin wrote: > On 3/27/24 12:23 PM, Tom de Vries wrote: >> On fedora rawhide, with test-case gdb.base/rtld-step.exp I get: >> ... >> static-pie-static-libc.c: In function '_start':^M >> static-pie-static-libc.c:1:22: error: \ >>    implicit declaration of function '_exit' >> [-Wimplicit-function-declaration]^M >>      1 | void _start (void) { _exit (0); }^M >>        |                      ^~~~~^M >> compiler exited with status 1 >>    ... >> UNTESTED: gdb.base/rtld-step.exp: failed to compile \ >>    (-static-pie not supported or static libc missing) >> ... >> >> Fix this by adding the missing include. >> >> Tested on aarch64-linux. > > Approved-By: John Baldwin > Hi John, thanks for the review. I had already committed after the approval of Kevin, so unfortunately this was committed without your approved-by tag. Thanks, - Tom