[PATCH] ppc: Fix return of instruction handlers in ppc_process_record_op63

[PATCH] ppc: Fix return of instruction handlers in ppc_process_record_op63

[Edjunior Barbosa Machado]

Hi,

some instruction handlers in ppc_process_record_op63() seem to be missing
return or incorrectly using break. This patch aims to fix that. Ok?

Thanks,
--
Edjunior

gdb/ChangeLog:
2016-09-21  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* rs6000-tdep.c (ppc_process_record_op63): Fix return of instruction
	handlers.

---
 gdb/rs6000-tdep.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index d7cf38f..1add498 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -5399,6 +5399,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache,
 				     tdep->ppc_fp0_regnum + PPC_FRT (insn));
       if (PPC_RC (insn))
 	record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);
+      return 0;
     }
 
   switch (ext & 0xff)
@@ -5462,7 +5463,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache,
       if (PPC_RC (insn))
 	record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);
       record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum);
-      break;
+      return 0;
 
     case 354:		/* DFP Extract Biased Exponent Quad */
       record_full_arch_list_add_reg (regcache,
@@ -5541,7 +5542,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache,
       if (PPC_RC (insn))
 	record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);
       record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum);
-      break;
+      return 0;
 
     case 0:		/* Floating Compare Unordered */
     case 32:		/* Floating Compare Ordered */
-- 
2.5.5

Re: [PATCH] ppc: Fix return of instruction handlers in ppc_process_record_op63

[Ulrich Weigand]

Edjunior Barbosa Machado wrote:

> some instruction handlers in ppc_process_record_op63() seem to be missing
> return or incorrectly using break. This patch aims to fix that. Ok?

Huh, good catch ...

> gdb/ChangeLog:
> 2016-09-21  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
> 
> 	* rs6000-tdep.c (ppc_process_record_op63): Fix return of instruction
> 	handlers.

This is OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com

Re: [PATCH] ppc: Fix return of instruction handlers in ppc_process_record_op63

[Edjunior Barbosa Machado]

On 09/21/2016 02:38 PM, Ulrich Weigand wrote:
> Edjunior Barbosa Machado wrote:
> 
>> some instruction handlers in ppc_process_record_op63() seem to be missing
>> return or incorrectly using break. This patch aims to fix that. Ok?
> 
> Huh, good catch ...
> 
>> gdb/ChangeLog:
>> 2016-09-21  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
>>
>> 	* rs6000-tdep.c (ppc_process_record_op63): Fix return of instruction
>> 	handlers.
> 
> This is OK.
> 
> Thanks,
> Ulrich

Thanks for the review, Uli. Just pushed to master:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=8aabe2e254e6a0419db9c6397c4068c69bfd95b0

--
Edjunior