From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19635 invoked by alias); 21 Sep 2016 17:52:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19569 invoked by uid 89); 21 Sep 2016 17:52:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*MI:vnet, H*m:vnet X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Sep 2016 17:52:00 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8LHmrat075620 for ; Wed, 21 Sep 2016 13:51:58 -0400 Received: from e24smtp02.br.ibm.com (e24smtp02.br.ibm.com [32.104.18.86]) by mx0a-001b2d01.pphosted.com with ESMTP id 25kta9qxks-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 21 Sep 2016 13:51:58 -0400 Received: from localhost by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Sep 2016 14:51:52 -0300 Received: from d24dlp02.br.ibm.com (9.18.248.206) by e24smtp02.br.ibm.com (10.172.0.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 21 Sep 2016 14:51:51 -0300 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.18.232.225]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id C44431DC006F for ; Wed, 21 Sep 2016 13:51:50 -0400 (EDT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.8.31.93]) by d24relay03.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8LHpo9836765894 for ; Wed, 21 Sep 2016 14:51:50 -0300 Received: from d24av02.br.ibm.com (localhost [127.0.0.1]) by d24av02.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8LHposw030145 for ; Wed, 21 Sep 2016 14:51:50 -0300 Received: from [9.78.144.155] ([9.78.144.155]) by d24av02.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u8LHpkkH030040; Wed, 21 Sep 2016 14:51:48 -0300 Subject: Re: [PATCH] ppc: Fix return of instruction handlers in ppc_process_record_op63 To: Ulrich Weigand References: <20160921173840.B1985100082@oc8523832656.ibm.com> Cc: gdb-patches@sourceware.org From: Edjunior Barbosa Machado Date: Wed, 21 Sep 2016 18:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160921173840.B1985100082@oc8523832656.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16092117-0020-0000-0000-000002462F8C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16092117-0021-0000-0000-0000304309A3 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-21_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609210323 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00268.txt.bz2 On 09/21/2016 02:38 PM, Ulrich Weigand wrote: > Edjunior Barbosa Machado wrote: > >> some instruction handlers in ppc_process_record_op63() seem to be missing >> return or incorrectly using break. This patch aims to fix that. Ok? > > Huh, good catch ... > >> gdb/ChangeLog: >> 2016-09-21 Edjunior Barbosa Machado >> >> * rs6000-tdep.c (ppc_process_record_op63): Fix return of instruction >> handlers. > > This is OK. > > Thanks, > Ulrich Thanks for the review, Uli. Just pushed to master: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=8aabe2e254e6a0419db9c6397c4068c69bfd95b0 -- Edjunior