From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Daniel Starke <daniel-email@gmx.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] gdb: Fix null pointer dereference on missing PATH variable
Date: Wed, 5 Mar 2025 10:51:58 -0500 [thread overview]
Message-ID: <e8283c0e-a05b-4007-9ce8-ca9650bfca78@simark.ca> (raw)
In-Reply-To: <87eczb1oq1.fsf@tromey.com>
On 3/5/25 10:28 AM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> I propose this little tweak shown below, changing the code to use
> Simon> gdb_printf instead of gdb_puts, if that's ok with you.
>
> Simon> + gdb_printf ("Executable and object file path: %s\n",
>
> Probably should use _() here.
>
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks, pushing with that fixed.
Simon
next prev parent reply other threads:[~2025-03-05 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 21:50 Daniel Starke
2025-03-05 3:38 ` Simon Marchi
2025-03-05 15:28 ` Tom Tromey
2025-03-05 15:51 ` Simon Marchi [this message]
2025-03-05 16:17 ` daniel-email
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8283c0e-a05b-4007-9ce8-ca9650bfca78@simark.ca \
--to=simark@simark.ca \
--cc=daniel-email@gmx.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox