Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Daniel Starke <daniel-email@gmx.net>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] gdb: Fix null pointer dereference on missing PATH variable
Date: Wed, 05 Mar 2025 08:28:22 -0700	[thread overview]
Message-ID: <87eczb1oq1.fsf@tromey.com> (raw)
In-Reply-To: <edfe6e17-1c20-4a4c-944f-247ff71b6c10@simark.ca> (Simon Marchi's message of "Tue, 4 Mar 2025 22:38:53 -0500")

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I propose this little tweak shown below, changing the code to use
Simon> gdb_printf instead of gdb_puts, if that's ok with you.

Simon> +  gdb_printf ("Executable and object file path: %s\n",

Probably should use _() here.

Approved-By: Tom Tromey <tom@tromey.com>

Tom

  reply	other threads:[~2025-03-05 15:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 21:50 Daniel Starke
2025-03-05  3:38 ` Simon Marchi
2025-03-05 15:28   ` Tom Tromey [this message]
2025-03-05 15:51     ` Simon Marchi
2025-03-05 16:17   ` daniel-email

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eczb1oq1.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=daniel-email@gmx.net \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox