From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id M8TVEd1tyGcq+QUAWB0awg (envelope-from ) for ; Wed, 05 Mar 2025 10:29:33 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KJ8SvplB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 37D811E105; Wed, 5 Mar 2025 10:29:33 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BFBF61E08E for ; Wed, 5 Mar 2025 10:29:32 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 720463858283 for ; Wed, 5 Mar 2025 15:29:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 720463858283 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KJ8SvplB Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id A42553858C30 for ; Wed, 5 Mar 2025 15:28:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A42553858C30 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A42553858C30 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741188506; cv=none; b=n4tBqPxTAG2ZFe3if5oAXFXrLxMV6kfpEph0keAhrefibGQPBarKU9RUIxsxqX9b4WDYf3u5dzvsweLI2ACmZlmnTJEgstNTEDbTVeCpX7pIg5heqYzdC35IG9LV9KmWTaFmKqu3LZx1Jm2BlSbiaQuRE+p7V9pXMz8cC10xJH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741188506; c=relaxed/simple; bh=3lht6cU+LetM3G/gVfC6LaP3S7Vp0cV34H/Kr/zDQBs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LxNgEEUi00m4ZRU4avEJGKmQEkFxf6orml/Padr9bifazVP2CyRLPsD1bGqaZSY+/OeBN4OxR9y+EkwBTFECredvcxVuLXdD4OMN2YPp3xOLVUK5acesSUtRmIOx2FdSwo1c+L8kgJyHz8oJ49hcOqyqkyNvJ4Swz4lf8Iau2A4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A42553858C30 Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id pqVvtTrYjiuzSpqfatvSsP; Wed, 05 Mar 2025 15:28:26 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id pqfYtGCxFdQylpqfZtpjzp; Wed, 05 Mar 2025 15:28:25 +0000 X-Authority-Analysis: v=2.4 cv=McOnuI/f c=1 sm=1 tr=0 ts=67c86d99 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Vs1iUdzkB0EA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=zstS-IiYAAAA:8 a=_nmxUJGCNDtlCTayus4A:9 a=b4DR9a7p2ZdsqdHBznES:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=684absH43ZDQfl4BbJDvm9bmNCDJYzGrKhs/XwQHcVs=; b=KJ8SvplBqC+SbhcOCy8lQi80CV tkq00zx42MnVMPEzHusXNmpA7c3pfgVSdGyb+0JOh+4JOiPWcj754ElukzG1YzTf8TZEVYhYWVL3q IyPw9f0TMZpNn5HeLSM6SwOHw; Received: from 97-118-51-80.hlrn.qwest.net ([97.118.51.80]:51966 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1tpqfY-00000001Fo1-0iRt; Wed, 05 Mar 2025 08:28:24 -0700 From: Tom Tromey To: Simon Marchi Cc: Daniel Starke , gdb-patches@sourceware.org Subject: Re: [PATCH 1/1] gdb: Fix null pointer dereference on missing PATH variable In-Reply-To: (Simon Marchi's message of "Tue, 4 Mar 2025 22:38:53 -0500") References: <20250304215011.2092-1-daniel-email@gmx.net> X-Attribution: Tom Date: Wed, 05 Mar 2025 08:28:22 -0700 Message-ID: <87eczb1oq1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.51.80 X-Source-L: No X-Exim-ID: 1tpqfY-00000001Fo1-0iRt X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-51-80.hlrn.qwest.net (murgatroyd) [97.118.51.80]:51966 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAmhhMYWmeSMhvkDr8ir0byM5mSD8WqW2wqj5ejMKuyeFFGymTNUAz1a2chP6iWSl4+HOUUghNBbcQtn7erBv+wITTY08JZGjcE1LXXM0s+Fu+oGdHrR dpM69+TJiVhhP9gr3FpiE8/J0ENFoog7y32zg1LEhI1eFduKFhjmgw1MWDMWXpBkn6ghNSRWAkzypgnE2+5MRiyBFifgwIQcqKk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> I propose this little tweak shown below, changing the code to use Simon> gdb_printf instead of gdb_puts, if that's ok with you. Simon> + gdb_printf ("Executable and object file path: %s\n", Probably should use _() here. Approved-By: Tom Tromey Tom