From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uKCUM2xzyGfD/gUAWB0awg (envelope-from ) for ; Wed, 05 Mar 2025 10:53:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1741189996; bh=GqpfwuHJlWOtEj/ZdXzB2rKsA+O/b8Hgq6pEccOib8M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mm/apQoB81Mn5qdbGSFSgDNTzWRSoE+3bW3syF0vSDNyYIz0qb/xACOrO3bSsiLnq ovwMJGetTaqu3wS7eMhA3EU+zkdTHoPsaz2zIYoa4eXSjNsrGavNCPzl391vHKwlCD KbqDbluK1j6UexX5XbxvIpJMgOnqQda5XoxeZFjA= Received: by simark.ca (Postfix, from userid 112) id BFFFA1E105; Wed, 5 Mar 2025 10:53:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=wQ002QtT; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=EErUoOhB; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 731CD1E08E for ; Wed, 5 Mar 2025 10:53:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 165F43858C2D for ; Wed, 5 Mar 2025 15:53:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 165F43858C2D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=wQ002QtT; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=EErUoOhB Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BB7C0385841E for ; Wed, 5 Mar 2025 15:52:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB7C0385841E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB7C0385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741189920; cv=none; b=otCHyIwf1pTk9aty9a3CWz7WUSM9Ii7Gpx4/QQaNVu5+ZYZMcSG6PPSg4WdRcV/N8ImjUpvVdOe6mwUsU/w71x1jE4Jkeh9h9fH1EZCuT1YbTdyqo8YSOXbr1N/MA3k75j0Apcu7EOyz5Zp2laAmsvrJFxmuO/14XZq02h0dnfY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741189920; c=relaxed/simple; bh=GqpfwuHJlWOtEj/ZdXzB2rKsA+O/b8Hgq6pEccOib8M=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=gdIzKXcs+L9hH/Nzo+xKS2jpvM2/swvTs2BaAdJ8bhWWvrYESbwIGbpn7b/G8Ag3DCEN1GwuzaR66lFCllxy7Ei1+CH9p+LE/2bdOtjM7hKc7u6E3FIliejx5et/JoSh4ZhXBiBtRSMLD1YhZkgPsvx4j0e3+OHxjbeNilOTeOA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB7C0385841E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1741189920; bh=GqpfwuHJlWOtEj/ZdXzB2rKsA+O/b8Hgq6pEccOib8M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=wQ002QtTzO9Z6a9c7d9QAqCIgd0a9x9QkWgjWywnG5rr4G4Mxvv7nTXXzFCii60VC E6xYqt3bhVmdaseDtYkv1jaEWx1/PIhm0EDM1J2Cl/C3zi9+gayyQ0jk1r7Qv0xyy+ TSwx5hcl82kTmQbCXkldZc4XLlIXAoJQ7R/kv7jk= Received: by simark.ca (Postfix, from userid 112) id 5D83A1E10A; Wed, 5 Mar 2025 10:52:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1741189919; bh=GqpfwuHJlWOtEj/ZdXzB2rKsA+O/b8Hgq6pEccOib8M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EErUoOhBYIkVRWTSOb38EzREniHACiWe3qvVSNGwpXD2v+7Bbni7GMRvsPtOWkQZq Ukcq8jMCBF+qy4idiKgmy2t4y94yFTanU+Mc7lgVnmpu4JzAYdgVMRHWs7QEbESo3M fgF/y2zHgHuq7Sx/lY1za0MEAKIuu8Tz8+65ZHnI= Received: from [172.16.0.192] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8CABE1E08E; Wed, 5 Mar 2025 10:51:59 -0500 (EST) Message-ID: Date: Wed, 5 Mar 2025 10:51:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] gdb: Fix null pointer dereference on missing PATH variable To: Tom Tromey Cc: Daniel Starke , gdb-patches@sourceware.org References: <20250304215011.2092-1-daniel-email@gmx.net> <87eczb1oq1.fsf@tromey.com> From: Simon Marchi Content-Language: fr In-Reply-To: <87eczb1oq1.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/5/25 10:28 AM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I propose this little tweak shown below, changing the code to use > Simon> gdb_printf instead of gdb_puts, if that's ok with you. > > Simon> + gdb_printf ("Executable and object file path: %s\n", > > Probably should use _() here. > > Approved-By: Tom Tromey > > Tom Thanks, pushing with that fixed. Simon