Re: [PATCH][gdb/testsuite] Fix break-probes.exp with native-gdbserver

[Tom de Vries <tdevries@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

On 18-04-19 20:13, Pedro Alves wrote:
> On 4/18/19 5:50 PM, Tom de Vries wrote:
>> Hi,
>>
>> When running break-probes.exp with native-gdbserver, we run into:
>> ...
>> FAIL: gdb.base/break-probes.exp: run til our library loads (the program exited)
>> FAIL: gdb.base/break-probes.exp: call (int) foo(23)
>> ...
>> due to the fact that we're trying to match:
>> ...
>> Inferior loaded /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
>>   /break-probes/break-probes-solib.so
>> ...
>> using pattern:
>> ...
>> Inferior loaded $sysroot$binfile_lib
>> ...
>> which expands into:
>> ...
>> Inferior loaded //data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
>>   /break-probes/break-probes-solib.so
>> ...
>>
>> Fix this by removing trailing slashes from the sysroot variable.
>>
>> Tested on x86_64-linux with native and native-gdbserver (with sysroot set to
>> "/", "/." and "/./").
>>
>> OK for trunk?
>>
> 
> I think we made a little mistake in the recent "set sysroot in board file" patch:
> 
> commit c92df149c29518f6e1d4a3174b3e29162fcd3ad6
> Author:     Alan Hayward <alan.hayward@arm.com>
> AuthorDate: Thu Mar 28 12:33:29 2019 +0000
> 
>     Testsuite: set sysroot when using gdbserver
> 
> I think it would be better to make that do
> 
> "set sysroot"
> 
> instead of the current
> 
> "set sysroot /"
> 
> Setting the sysroot to empty means to read from the local filesystem,
> which is what was intended.
> 
> And with that, this patch shouldn't be necessary.

Ack, committed as below.

Thanks,
- Tom


[-- Attachment #2: 0001-gdb-testsuite-Fix-gdb.base-break-probes.exp-with-native-gdbserver.patch --]
[-- Type: text/x-patch, Size: 1877 bytes --]

[gdb/testsuite] Fix gdb.base/break-probes.exp with native-gdbserver

When running break-probes.exp with native-gdbserver, we run into:
...
FAIL: gdb.base/break-probes.exp: run til our library loads (the program exited)
FAIL: gdb.base/break-probes.exp: call (int) foo(23)
...
due to the fact that we're trying to match:
...
Inferior loaded /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
  /break-probes/break-probes-solib.so
...
using pattern:
...
Inferior loaded $sysroot$binfile_lib
...
which expands into:
...
Inferior loaded //data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
  /break-probes/break-probes-solib.so
...

Fix by setting sysroot to "" in local-board.exp.

Tested on x86_64-linux with native-gdbserver.

gdb/testsuite/ChangeLog:

2019-04-18  Tom de Vries  <tdevries@suse.de>

	PR gdb/24433
	* boards/local-board.exp: Set sysroot to "".

---
 gdb/testsuite/ChangeLog              | 5 +++++
 gdb/testsuite/boards/local-board.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index bdabbba8d6..297e2d48c6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-04-18  Tom de Vries  <tdevries@suse.de>
+
+	PR gdb/24433
+	* boards/local-board.exp: Set sysroot to "".
+
 2019-04-18  Tom de Vries  <tdevries@suse.de>
 	    Pedro Alves  <palves@redhat.com>
 
diff --git a/gdb/testsuite/boards/local-board.exp b/gdb/testsuite/boards/local-board.exp
index bf710f4632..6e0448c58a 100644
--- a/gdb/testsuite/boards/local-board.exp
+++ b/gdb/testsuite/boards/local-board.exp
@@ -24,4 +24,4 @@ set baseboard [lindex [split $board "/"] 0]
 set board_info($baseboard,isremote) 0
 
 # Set sysroot to avoid sending files via the remote protocol.
-set GDBFLAGS "${GDBFLAGS} -ex \"set sysroot /\""
+set GDBFLAGS "${GDBFLAGS} -ex \"set sysroot\""