Re: [PATCH][gdb/testsuite] Fix break-probes.exp with native-gdbserver

[Pedro Alves <palves@redhat.com>]

On 4/18/19 5:50 PM, Tom de Vries wrote:
> Hi,
> 
> When running break-probes.exp with native-gdbserver, we run into:
> ...
> FAIL: gdb.base/break-probes.exp: run til our library loads (the program exited)
> FAIL: gdb.base/break-probes.exp: call (int) foo(23)
> ...
> due to the fact that we're trying to match:
> ...
> Inferior loaded /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
>   /break-probes/break-probes-solib.so
> ...
> using pattern:
> ...
> Inferior loaded $sysroot$binfile_lib
> ...
> which expands into:
> ...
> Inferior loaded //data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
>   /break-probes/break-probes-solib.so
> ...
> 
> Fix this by removing trailing slashes from the sysroot variable.
> 
> Tested on x86_64-linux with native and native-gdbserver (with sysroot set to
> "/", "/." and "/./").
> 
> OK for trunk?
> 

I think we made a little mistake in the recent "set sysroot in board file" patch:

commit c92df149c29518f6e1d4a3174b3e29162fcd3ad6
Author:     Alan Hayward <alan.hayward@arm.com>
AuthorDate: Thu Mar 28 12:33:29 2019 +0000

    Testsuite: set sysroot when using gdbserver

I think it would be better to make that do

"set sysroot"

instead of the current

"set sysroot /"

Setting the sysroot to empty means to read from the local filesystem,
which is what was intended.

And with that, this patch shouldn't be necessary.

Thanks,
Pedro Alves