From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH][gdb/testsuite] Fix break-probes.exp with native-gdbserver
Date: Thu, 18 Apr 2019 16:50:00 -0000 [thread overview]
Message-ID: <20190418165011.GA14803@delia> (raw)
Hi,
When running break-probes.exp with native-gdbserver, we run into:
...
FAIL: gdb.base/break-probes.exp: run til our library loads (the program exited)
FAIL: gdb.base/break-probes.exp: call (int) foo(23)
...
due to the fact that we're trying to match:
...
Inferior loaded /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
/break-probes/break-probes-solib.so
...
using pattern:
...
Inferior loaded $sysroot$binfile_lib
...
which expands into:
...
Inferior loaded //data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
/break-probes/break-probes-solib.so
...
Fix this by removing trailing slashes from the sysroot variable.
Tested on x86_64-linux with native and native-gdbserver (with sysroot set to
"/", "/." and "/./").
OK for trunk?
Thanks,
- Tom
[gdb/testsuite] Fix break-probes.exp with native-gdbserver
gdb/testsuite/ChangeLog:
2019-04-18 Tom de Vries <tdevries@suse.de>
PR gdb/24433
* gdb.base/break-probes.exp: Remove trailing slash from sysroot
variable.
---
gdb/testsuite/gdb.base/break-probes.exp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gdb/testsuite/gdb.base/break-probes.exp b/gdb/testsuite/gdb.base/break-probes.exp
index ca9a7841f1..3c826e1aad 100644
--- a/gdb/testsuite/gdb.base/break-probes.exp
+++ b/gdb/testsuite/gdb.base/break-probes.exp
@@ -70,6 +70,9 @@ if { $using_probes } {
}
}
+ # Remove trailing slash.
+ regsub {/$} "$sysroot" "" sysroot
+
# GDB strips "target:" from the start of filenames
# when operating on the local filesystem
regsub "^target:" "$sysroot" "(target:)?" sysroot
next reply other threads:[~2019-04-18 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 16:50 Tom de Vries [this message]
2019-04-18 18:13 ` Pedro Alves
2019-04-18 21:42 ` Tom de Vries
2019-05-08 2:09 ` Simon Marchi
2019-05-24 7:50 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418165011.GA14803@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox