From: Pedro Alves <palves@redhat.com>
To: Weimin Pan <weimin.pan@oracle.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3 PR gdb/16959] gdb hangs in infinite recursion
Date: Sat, 24 Mar 2018 10:10:00 -0000 [thread overview]
Message-ID: <e5d04e4b-384d-6c27-1b31-7ab0383f417e@redhat.com> (raw)
In-Reply-To: <1521840352-75024-1-git-send-email-weimin.pan@oracle.com>
On 03/23/2018 09:25 PM, Weimin Pan wrote:
> - if (TYPE_CODE (type) == TYPE_CODE_STRUCT)
> + struct type *real_type = check_typedef (type);
> + if (TYPE_CODE (real_type) == TYPE_CODE_STRUCT)
> {
> CORE_ADDR *first_dont_print;
> CORE_ADDR addr;
> @@ -658,15 +659,14 @@ cp_print_static_field (struct type *type,
> addr = value_address (val);
> obstack_grow (&dont_print_statmem_obstack, (char *) &addr,
> sizeof (CORE_ADDR));
> - type = check_typedef (type);
> - cp_print_value_fields (type, value_enclosing_type (val),
> + cp_print_value_fields (real_type, value_enclosing_type (val),
This is still passing the resolved type down instead of the
original type.
Pedro Alves
next prev parent reply other threads:[~2018-03-24 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 21:51 Weimin Pan
2018-03-24 2:41 ` Simon Marchi
2018-03-24 19:41 ` Wei-min Pan
2018-03-24 19:51 ` Simon Marchi
2018-03-26 22:28 ` Weimin Pan
2018-03-24 10:10 ` Pedro Alves [this message]
2018-03-24 12:33 ` Simon Marchi
2018-03-24 18:56 ` Wei-min Pan
2018-03-24 19:23 ` Simon Marchi
2018-03-24 19:32 ` Wei-min Pan
2018-03-24 19:48 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d04e4b-384d-6c27-1b31-7ab0383f417e@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox