From: Simon Marchi <simon.marchi@polymtl.ca>
To: Wei-min Pan <weimin.pan@oracle.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3 PR gdb/16959] gdb hangs in infinite recursion
Date: Sat, 24 Mar 2018 19:48:00 -0000 [thread overview]
Message-ID: <dee094f46437ae23cacf7c272c43cbf5@polymtl.ca> (raw)
In-Reply-To: <1fdfd913-55d2-121a-6228-8e99e3ed4619@oracle.com>
On 2018-03-24 15:32, Wei-min Pan wrote:
> The original code is like:
>
> - Â Â Â type = check_typedef (type);
> -Â Â Â Â Â cp_print_value_fields (type, value_enclosing_type (val),
>
> So it's passing the real type. Do you think that we still need to pass
> the original type?
As I explained, I think it would be a good general rule/convention. And
since cp_print_value_fields does it's own check_typedef, it shouldn't
change the behavior.
Simon
prev parent reply other threads:[~2018-03-24 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 21:51 Weimin Pan
2018-03-24 2:41 ` Simon Marchi
2018-03-24 19:41 ` Wei-min Pan
2018-03-24 19:51 ` Simon Marchi
2018-03-26 22:28 ` Weimin Pan
2018-03-24 10:10 ` Pedro Alves
2018-03-24 12:33 ` Simon Marchi
2018-03-24 18:56 ` Wei-min Pan
2018-03-24 19:23 ` Simon Marchi
2018-03-24 19:32 ` Wei-min Pan
2018-03-24 19:48 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dee094f46437ae23cacf7c272c43cbf5@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox