From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47930 invoked by alias); 24 Mar 2018 10:10:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47920 invoked by uid 89); 24 Mar 2018 10:10:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:733 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Mar 2018 10:10:34 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2CE24270949; Sat, 24 Mar 2018 10:10:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C8DF215CDA7; Sat, 24 Mar 2018 10:10:32 +0000 (UTC) Subject: Re: [PATCH 3 PR gdb/16959] gdb hangs in infinite recursion To: Weimin Pan , gdb-patches@sourceware.org References: <1521840352-75024-1-git-send-email-weimin.pan@oracle.com> From: Pedro Alves Message-ID: Date: Sat, 24 Mar 2018 10:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521840352-75024-1-git-send-email-weimin.pan@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00479.txt.bz2 On 03/23/2018 09:25 PM, Weimin Pan wrote: > - if (TYPE_CODE (type) == TYPE_CODE_STRUCT) > + struct type *real_type = check_typedef (type); > + if (TYPE_CODE (real_type) == TYPE_CODE_STRUCT) > { > CORE_ADDR *first_dont_print; > CORE_ADDR addr; > @@ -658,15 +659,14 @@ cp_print_static_field (struct type *type, > addr = value_address (val); > obstack_grow (&dont_print_statmem_obstack, (char *) &addr, > sizeof (CORE_ADDR)); > - type = check_typedef (type); > - cp_print_value_fields (type, value_enclosing_type (val), > + cp_print_value_fields (real_type, value_enclosing_type (val), This is still passing the resolved type down instead of the original type. Pedro Alves