From: Pedro Alves <palves@redhat.com>
To: John Baldwin <jhb@freebsd.org>, gdb-patches@sourceware.org
Cc: Yao Qi <qiyaoltc@gmail.com>
Subject: Re: [PATCH] gdb: Use vector::emplace_back
Date: Wed, 09 Nov 2016 18:45:00 -0000 [thread overview]
Message-ID: <e50f77b3-7162-254b-9c48-9b29bad5ab4a@redhat.com> (raw)
In-Reply-To: <2148985.sxa6D4FU0N@ralph.baldwin.cx>
On 11/09/2016 05:08 PM, John Baldwin wrote:
>> This:
>>
>> cmdarg (cmdarg_kind type, char *string)
>> : this->type (type), this->string (string)
>> {}
>>
>> is not valid C++ and does _not_ compile:
>
> No, but this compiles:
>
> cmdarg (cmdarg_kind type, char *string)
> : type (type), string (string)
> {}
>
> I converted a non-trivial C++ code base both to C++11 and to compile with
> -Wshadow (two of several different passes). There were many instances of the
> style above that all had to be changed to compile with -Wshadow.
Ah! I stand corrected. Then it is about -Wshadow after all.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-11-09 18:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 0:39 Pedro Alves
2016-11-09 11:12 ` Yao Qi
2016-11-09 12:21 ` Pedro Alves
2016-11-09 12:43 ` Yao Qi
2016-11-09 12:55 ` Pedro Alves
2016-11-09 14:50 ` John Baldwin
2016-11-09 15:27 ` Pedro Alves
2016-11-09 17:08 ` John Baldwin
2016-11-09 18:45 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e50f77b3-7162-254b-9c48-9b29bad5ab4a@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox