From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Use vector::emplace_back
Date: Wed, 09 Nov 2016 11:12:00 -0000 [thread overview]
Message-ID: <CAH=s-PN18zXqL7RYRfQiX=0Sg-0kYtZ-LyLDYz4O4_+jNpE=mw@mail.gmail.com> (raw)
In-Reply-To: <1478651991-5083-1-git-send-email-palves@redhat.com>
Hi Pedro,
Patch is good to me, a question on coding style below,
On Wed, Nov 9, 2016 at 12:39 AM, Pedro Alves <palves@redhat.com> wrote:
> /* Arguments of --command option and its counterpart. */
> -struct cmdarg {
> +struct cmdarg
> +{
> + cmdarg (cmdarg_kind type_, char *string_)
> + : type (type_), string (string_)
> + {}
> +
Is there any reason you name parameters with tailing "_"? I don't
see anything about tailing "_" in GDB or GCC C++ code standard.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-11-09 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 0:39 Pedro Alves
2016-11-09 11:12 ` Yao Qi [this message]
2016-11-09 12:21 ` Pedro Alves
2016-11-09 12:43 ` Yao Qi
2016-11-09 12:55 ` Pedro Alves
2016-11-09 14:50 ` John Baldwin
2016-11-09 15:27 ` Pedro Alves
2016-11-09 17:08 ` John Baldwin
2016-11-09 18:45 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=s-PN18zXqL7RYRfQiX=0Sg-0kYtZ-LyLDYz4O4_+jNpE=mw@mail.gmail.com' \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox