From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129783 invoked by alias); 9 Nov 2016 11:12:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129727 invoked by uid 89); 9 Nov 2016 11:12:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.216.195, Hx-spam-relays-external:209.85.216.195 X-HELO: mail-qt0-f195.google.com Received: from mail-qt0-f195.google.com (HELO mail-qt0-f195.google.com) (209.85.216.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Nov 2016 11:12:50 +0000 Received: by mail-qt0-f195.google.com with SMTP id l20so8615219qta.1 for ; Wed, 09 Nov 2016 03:12:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WhPKafPXGafuU5cGkn5s5ecE0kjGFQmZO/XR0P2tSu4=; b=bSEoJhlDR5v8UtKqtZKf1KIsAJYMDOm8I6s2c/90wQQi2vc3x2uJUEtByDJUAst65v 7lLodlHTPdniKYi8XSUnn14p1HbK9vVpkHWEK1/hAXx5xOeBIIXjpgL7Qyf44FGYKsro EjlR5/FnW510h9NIOCpm6dDwYc2wwPO+ufUi9abMYrnTsYxOEw7EY+hJ8oqX8GJPqzm8 oAofpSRmM/UxGQklQz4gpdD4+UGsqHK4a1Jw3ZykMJfE7jmps0YE3k2bGVhQHqVxNSBV iaLX65JbXBM8BR9LuaZTNc6LO51FOsscKJhzSj5PTvlMM1hewNkGesrI9JZbM3EbD5tn DnIA== X-Gm-Message-State: ABUngvdKPkqj9sGn0VAnu7aMaVXMhLyqGBEdAbkzMe/OO2NSlyQkF/Z7dX4flwxIqWQBfQI7/49aaGNJva+URA== X-Received: by 10.200.49.247 with SMTP id i52mr18362947qte.108.1478689968451; Wed, 09 Nov 2016 03:12:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.149.55 with HTTP; Wed, 9 Nov 2016 03:12:48 -0800 (PST) In-Reply-To: <1478651991-5083-1-git-send-email-palves@redhat.com> References: <1478651991-5083-1-git-send-email-palves@redhat.com> From: Yao Qi Date: Wed, 09 Nov 2016 11:12:00 -0000 Message-ID: Subject: Re: [PATCH] gdb: Use vector::emplace_back To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00207.txt.bz2 Hi Pedro, Patch is good to me, a question on coding style below, On Wed, Nov 9, 2016 at 12:39 AM, Pedro Alves wrote: > /* Arguments of --command option and its counterpart. */ > -struct cmdarg { > +struct cmdarg > +{ > + cmdarg (cmdarg_kind type_, char *string_) > + : type (type_), string (string_) > + {} > + Is there any reason you name parameters with tailing "_"? I don't see anything about tailing "_" in GDB or GCC C++ code standard. --=20 Yao (=E9=BD=90=E5=B0=A7)