From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50865 invoked by alias); 9 Nov 2016 18:45:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50791 invoked by uid 89); 9 Nov 2016 18:45:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ah, stand X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Nov 2016 18:45:22 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0B22C04D2EC; Wed, 9 Nov 2016 18:45:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA9IjJRD006561; Wed, 9 Nov 2016 13:45:19 -0500 Subject: Re: [PATCH] gdb: Use vector::emplace_back To: John Baldwin , gdb-patches@sourceware.org References: <1478651991-5083-1-git-send-email-palves@redhat.com> <1575403.749fUSKQim@ralph.baldwin.cx> <79425cad-160f-d1a2-3275-29605db7a7cb@redhat.com> <2148985.sxa6D4FU0N@ralph.baldwin.cx> Cc: Yao Qi From: Pedro Alves Message-ID: Date: Wed, 09 Nov 2016 18:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2148985.sxa6D4FU0N@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00234.txt.bz2 On 11/09/2016 05:08 PM, John Baldwin wrote: >> This: >> >> cmdarg (cmdarg_kind type, char *string) >> : this->type (type), this->string (string) >> {} >> >> is not valid C++ and does _not_ compile: > > No, but this compiles: > > cmdarg (cmdarg_kind type, char *string) > : type (type), string (string) > {} > > I converted a non-trivial C++ code base both to C++11 and to compile with > -Wshadow (two of several different passes). There were many instances of the > style above that all had to be changed to compile with -Wshadow. Ah! I stand corrected. Then it is about -Wshadow after all. Thanks, Pedro Alves