From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org, eliz@gnu.org
Subject: Re: [PATCH v2, doc] python: Provide textual representation for Inferior and Objfile
Date: Thu, 13 Sep 2018 15:57:00 -0000 [thread overview]
Message-ID: <e495af161d002b99a59931378972197e@polymtl.ca> (raw)
In-Reply-To: <87d0thqxas.fsf@tromey.com>
On 2018-09-13 10:36, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> +gdb_test "python print (inferiors)" "\\(<gdb.Inferior num=1,
> pid=$decimal>,\\)" "verify inferiors list"
>
> Some of the new test lines run over 80 characters.
Most of them are easy enough to make fit in 80 chars, but one is still
over, because it has a long match pattern string. My understanding was
that we were a bit more lenient on the line length for those gdb_test
lines (splitting the patterns just to comply to that rule would just
make them less readable).
> Other than that nit the patch looks good to me.
Thanks, I pushed it with those fixed as much as I can. I also addressed
Eli's comment about repr() and str().
Simon
next prev parent reply other threads:[~2018-09-13 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 20:55 [PATCH] " Simon Marchi
2018-09-12 22:07 ` Tom Tromey
2018-09-12 22:10 ` Simon Marchi
2018-09-12 22:50 ` [PATCH v2, doc] " Simon Marchi
2018-09-13 13:39 ` Eli Zaretskii
2018-09-13 14:37 ` Tom Tromey
2018-09-13 15:57 ` Simon Marchi [this message]
2018-09-13 15:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e495af161d002b99a59931378972197e@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox