From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2, doc] python: Provide textual representation for Inferior and Objfile
Date: Thu, 13 Sep 2018 14:37:00 -0000 [thread overview]
Message-ID: <87d0thqxas.fsf@tromey.com> (raw)
In-Reply-To: <20180912225001.8701-1-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 12 Sep 2018 18:50:01 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> +gdb_test "python print (inferiors)" "\\(<gdb.Inferior num=1, pid=$decimal>,\\)" "verify inferiors list"
Some of the new test lines run over 80 characters.
Other than that nit the patch looks good to me.
Tom
next prev parent reply other threads:[~2018-09-13 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 20:55 [PATCH] " Simon Marchi
2018-09-12 22:07 ` Tom Tromey
2018-09-12 22:10 ` Simon Marchi
2018-09-12 22:50 ` [PATCH v2, doc] " Simon Marchi
2018-09-13 13:39 ` Eli Zaretskii
2018-09-13 14:37 ` Tom Tromey [this message]
2018-09-13 15:57 ` Simon Marchi
2018-09-13 15:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0thqxas.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox